-
Notifications
You must be signed in to change notification settings - Fork 229
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Ensure logging is initialized only once #518
Ensure logging is initialized only once #518
Conversation
699bf4b
to
0d9c49c
Compare
Rebased after #497 went in. |
CI jobs in ros2/rcl#579 (comment). |
Signed-off-by: Ivan Santiago Paunovic <[email protected]>
Signed-off-by: Ivan Santiago Paunovic <[email protected]>
Signed-off-by: Ivan Santiago Paunovic <[email protected]>
0d9c49c
to
da86a77
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Signed-off-by: Ivan Santiago Paunovic <[email protected]>
@@ -73,6 +85,7 @@ def shutdown(self): | |||
with self._handle as capsule, self._lock: | |||
rclpy_implementation.rclpy_shutdown(capsule) | |||
self._call_on_shutdown_callbacks() | |||
self._logging_fini() |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@ivanpauno any idea why this is not called from try_shutdown()
as well?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
no, I guess that was only a mistake.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
#800 should fix it
Connects to ros2/rcl#579.
Connects to ros2/rclcpp#998.