Make rmw_destroy_wait_set return RMW_RET_INVALID_ARGUMENT (#152)

Signed-off-by: Christophe Bedard <[email protected]>
ros2 · Jun 13, 2024 · 1bb128b · 1bb128b
1 parent 2cb888d
commit 1bb128b
Showing 1 changed file with 1 addition and 3 deletions.
diff --git a/rmw_connextdds_common/src/common/rmw_waitset.cpp b/rmw_connextdds_common/src/common/rmw_waitset.cpp
@@ -105,9 +105,7 @@ rmw_api_connextdds_create_wait_set(
 rmw_ret_t
 rmw_api_connextdds_destroy_wait_set(rmw_wait_set_t * rmw_ws)
 {
-  // TODO(asorbini): Return RMW_RET_INVALID_ARGUMENT. We return RMW_RET_ERROR
-  // because that's what's expected by test_rmw_implementation
-  RMW_CHECK_ARGUMENT_FOR_NULL(rmw_ws, RMW_RET_ERROR);
+  RMW_CHECK_ARGUMENT_FOR_NULL(rmw_ws, RMW_RET_INVALID_ARGUMENT);
   RMW_CHECK_TYPE_IDENTIFIERS_MATCH(
     rmw_ws,
     rmw_ws->implementation_identifier,