Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

introduce RMW_EVENT_TYPE_MAX in rmw_event_type_t. #162

Merged
merged 1 commit into from
Feb 5, 2025
Merged

introduce RMW_EVENT_TYPE_MAX in rmw_event_type_t. #162

merged 1 commit into from
Feb 5, 2025

Conversation

fujitatomoya
Copy link
Collaborator

depends on ros2/rmw#380

@fujitatomoya fujitatomoya mentioned this pull request Oct 11, 2024
Merged
fujitatomoya
fujitatomoya commented Oct 11, 2024
View reviewed changes
Copy link
Collaborator Author

@fujitatomoya fujitatomoya left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

reference why we change this: ros2/rmw#380 (comment)

@fujitatomoya
Copy link
Collaborator Author

Pulls: ros2/rmw#380, #162, ros2/rmw_fastrtps#785
Gist: https://gist.githubusercontent.com/fujitatomoya/287bc10787b6388b8c13bf6fdfa4d974/raw/ec909bd20c342c882a27450c57dc05ce62d209b5/ros2.repos
BUILD args: --packages-above-and-dependencies rmw rmw_connextdds_common rmw_fastrtps_shared_cpp
TEST args: --packages-above rmw rmw_connextdds_common rmw_fastrtps_shared_cpp
ROS Distro: rolling
Job: ci_launcher
ci_launcher ran: https://ci.ros2.org/job/ci_launcher/14697

  • Linux Build Status
  • Linux-aarch64 Build Status
  • Linux-rhel Build Status
  • Windows Build Status

@fujitatomoya fujitatomoya mentioned this pull request Oct 11, 2024
Merged
@fujitatomoya
Copy link
Collaborator Author

Pulls: ros2/rmw#380, ros2/rmw_fastrtps#785, #162, ros2/rmw_cyclonedds#518
Gist: https://gist.githubusercontent.com/fujitatomoya/a5a27e64c97e3b687ed9c85018393aef/raw/398849da025367226392ce4eacd4f8114a09b768/ros2.repos
BUILD args: --packages-above-and-dependencies rmw rmw_fastrtps_shared_cpp rmw_connextdds_common rmw_cyclonedds_cpp
TEST args: --packages-above rmw rmw_fastrtps_shared_cpp rmw_connextdds_common rmw_cyclonedds_cpp
ROS Distro: rolling
Job: ci_launcher
ci_launcher ran: https://ci.ros2.org/job/ci_launcher/14711

  • Linux Build Status
  • Linux-aarch64 Build Status
  • Linux-rhel Build Status
  • Windows Build Status

@fujitatomoya fujitatomoya mentioned this pull request Oct 16, 2024
Merged
@fujitatomoya
Copy link
Collaborator Author

Pulls: ros2/rmw#380, ros2/rmw_fastrtps#785, #162, ros2/rmw_cyclonedds#518
Gist: https://gist.githubusercontent.com/fujitatomoya/6abc026e02c2c115a589c04c79e23c39/raw/398849da025367226392ce4eacd4f8114a09b768/ros2.repos
BUILD args: --packages-above-and-dependencies rmw rmw_fastrtps_shared_cpp rmw_connextdds_common rmw_cyclonedds_cpp
TEST args: --packages-above rmw rmw_fastrtps_shared_cpp rmw_connextdds_common rmw_cyclonedds_cpp
ROS Distro: rolling
Job: ci_launcher
ci_launcher ran: https://ci.ros2.org/job/ci_launcher/14714

  • Linux Build Status
  • Linux-aarch64 Build Status
  • Linux-rhel Build Status
  • Windows Build Status

@fujitatomoya
Copy link
Collaborator Author

Pulls: ros2/rmw#380, ros2/rmw_fastrtps#785, #162, ros2/rmw_cyclonedds#518
Gist: https://gist.githubusercontent.com/fujitatomoya/82891bb189950fefcf68c0f191365af1/raw/398849da025367226392ce4eacd4f8114a09b768/ros2.repos
BUILD args: --packages-above-and-dependencies rmw rmw_fastrtps_shared_cpp rmw_connextdds_common rmw_cyclonedds_cpp
TEST args: --packages-above rmw rmw_fastrtps_shared_cpp rmw_connextdds_common rmw_cyclonedds_cpp
ROS Distro: rolling
Job: ci_launcher
ci_launcher ran: https://ci.ros2.org/job/ci_launcher/14720

  • Linux Build Status
  • Linux-aarch64 Build Status
  • Linux-rhel Build Status
  • Windows Build Status

@fujitatomoya
Copy link
Collaborator Author

Pulls: ros2/rmw#380, ros2/rmw_fastrtps#785, #162, ros2/rmw_cyclonedds#518
Gist: https://gist.githubusercontent.com/fujitatomoya/16961ebf1f4059173817c9730b42d685/raw/398849da025367226392ce4eacd4f8114a09b768/ros2.repos
BUILD args: --packages-above-and-dependencies rmw rmw_fastrtps_shared_cpp rmw_connextdds_common rmw_cyclonedds_cpp
TEST args: --packages-above rmw rmw_fastrtps_shared_cpp rmw_connextdds_common rmw_cyclonedds_cpp
ROS Distro: rolling
Job: ci_launcher
ci_launcher ran: https://ci.ros2.org/job/ci_launcher/14722

  • Linux Build Status
  • Linux-aarch64 Build Status
  • Linux-rhel Build Status
  • Windows Build Status

@fujitatomoya
Copy link
Collaborator Author

fujitatomoya commented Oct 19, 2024 •
edited
Loading

Pulls: ros2/rmw#380, ros2/rmw_fastrtps#785, #162, ros2/rmw_cyclonedds#518
Gist: https://gist.githubusercontent.com/fujitatomoya/065211cb8895027ee0a710a50b6a9851/raw/398849da025367226392ce4eacd4f8114a09b768/ros2.repos
BUILD args: --packages-above-and-dependencies rmw rmw_fastrtps_shared_cpp rmw_connextdds_common rmw_cyclonedds_cpp
TEST args: --packages-above rmw rmw_fastrtps_shared_cpp rmw_connextdds_common rmw_cyclonedds_cpp
ROS Distro: rolling
Job: ci_launcher
ci_launcher ran: https://ci.ros2.org/job/ci_launcher/14726

  • Linux Build Status
  • Linux-aarch64 Build Status
  • Linux-rhel Build Status
  • Windows Build Status

@fujitatomoya
Copy link
Collaborator Author

@trubio-rti can you take a look at this?

@fgallegosalido
Copy link
Collaborator

Hi @fujitatomoya, @trubio-rti is no longer working on the Connext RMW. @lobolanja and I will be the point of contact moving forward.

Do you need a review of the pull request? If so, add me as a reviewer

@fujitatomoya
Copy link
Collaborator Author

@fgallegosalido

Do you need a review of the pull request? If so, add me as a reviewer

yes i do. and done!

@fujitatomoya
introduce RMW_EVENT_TYPE_MAX in rmw_event_type_t.
6190035 
Signed-off-by: Tomoya Fujita <Tomoya.Fujita@sony.com>
@fujitatomoya fujitatomoya force-pushed the fujitatomoya/return-zero-structure branch from 413b945 to 6190035 Compare February 4, 2025 22:19
@fujitatomoya
Copy link
Collaborator Author

fujitatomoya commented Feb 4, 2025 •
edited
Loading

Pulls: ros2/rmw#380, #162, ros2/rmw_fastrtps#785, ros2/rmw_cyclonedds#518
Gist: https://gist.githubusercontent.com/fujitatomoya/29f611cd228c356fd94dc372b220b0ba/raw/5dc544053744c46415545fe90336becf878d9765/ros2.repos
BUILD args: --packages-above-and-dependencies rmw rmw_fastrtps_shared_cpp rmw_connextdds_common rmw_cyclonedds_cpp
TEST args: --packages-above rmw rmw_fastrtps_shared_cpp rmw_connextdds_common rmw_cyclonedds_cpp
ROS Distro: rolling
Job: ci_launcher
ci_launcher ran: https://ci.ros2.org/job/ci_launcher/15120

  • Linux Build Status
  • Linux-aarch64 Build Status
  • Linux-rhel Build Status
  • Windows Build Status

@fujitatomoya fujitatomoya merged commit 99a271e into rolling Feb 5, 2025
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fgallegosalido fgallegosalido fgallegosalido approved these changes

@lobolanja lobolanja lobolanja approved these changes

@clalancette clalancette Awaiting requested review from clalancette

Assignees

@clalancette clalancette

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@fujitatomoya @fgallegosalido @lobolanja @clalancette