Provide a dummy readcdr function if needed #160
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Erik Boasson <[email protected]>
|
No longer applicable now that #145 has been merged. The change would be potentially be useful for dashing/eloquent, but just retargetting the PR is not a practical approach. Closing. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Current master has a custom reader history cache (RHC) for monitoring the changes to the node graph without having to waste memory on it. eclipse-cyclonedds/cyclonedds#499 at long last adds a companion
dds_readcdrto the existingdds_takecdrthat this RMW layer has depended on for a long time, and so the custom RHC needs to updated with a trivial implementation.#145 changes the mapping of ROS nodes to participants and uses the "graph cache" implemented in
rmw_dds_common. In that setting, there is no use for this custom RHC and so this PR doesn't apply after #145 has been merged.