Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Exclude other RMW from Github CI build #168

Merged
merged 1 commit into from
Apr 29, 2020

Conversation

rotu
Copy link
Collaborator

@rotu rotu commented Apr 25, 2020

Since #145, the CI build of rmw_cyclonedds_cpp has been failing on Windows due to inadvertently injecting fastrtps into the build process.
fastrtps fails to build (eProsima/Fast-DDS#1173) causing the CI to fail.
There doesn't seem to be a better way to suppress this in action-ros-ci ros-tooling/action-ros-ci#177

Fixes #164

@rotu rotu marked this pull request as draft April 28, 2020 20:21
@rotu rotu force-pushed the suppress_rmw branch 2 times, most recently from 705302c to cd7e2f3 Compare April 28, 2020 21:03
Since ros2#145, the CI build of rmw_cyclonedds_cpp has been failing on Windows due to inadvertently injecting fastrtps into the build process.
fastrtps fails to build (eProsima/Fast-DDS#1173) causing the CI to fail.
There doesn't seem to be a better way to suppress this in action-ros-ci ros-tooling/action-ros-ci#177

Fixes ros2#164
@rotu rotu marked this pull request as ready for review April 28, 2020 21:19
@rotu rotu requested review from eboasson and thomas-moulard April 28, 2020 22:53
@rotu rotu assigned rotu and unassigned rotu Apr 28, 2020
Copy link
Member

@ivanpauno ivanpauno left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

It would be better if the actions have support for ignoring specific packages, but until then this does the job well.

Copy link
Collaborator

@eboasson eboasson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Clever!

@rotu rotu merged commit 3397c95 into ros2:master Apr 29, 2020
@rotu rotu deleted the suppress_rmw branch April 29, 2020 17:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Master CI installing FastRTPS from binary
3 participants