Reset security related RMW error state. #172
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
If security support is not required, the lack of it is not an error. Signed-off-by: Michel Hidalgo <[email protected]>
ivanpauno
approved these changes
Apr 28, 2020
There was a problem hiding this comment.
I've just hit the same problem (#123 (comment)).
I've tried this locally and it does work.
LGTM!
kyrofa
reviewed
Apr 28, 2020
| @@ -922,6 +922,8 @@ extern "C" rmw_ret_t rmw_init(const rmw_init_options_t * options, rmw_context_t | |||
| if (context->options.security_options.enforce_security == RMW_SECURITY_ENFORCEMENT_ENFORCE) { | |||
| return RMW_RET_ERROR; | |||
| } | |||
| // No security enforced, lack of support is not an error. | |||
| rmw_reset_error(); | |||
There was a problem hiding this comment.
I think setting the error state is a bug anyway, fixing it like this feels a tad kludgey. I instead suggest surrounding the generation of the error message with an if (security_options->security_root_path != nullptr). If security_root_path == nullptr I'd just return OK, since nothing was requested and we did nothing.
Merged
|
Closing in favor of #175 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If security support is not required, the lack of it is not an error. I think this was introduced in #145.
Without this patch, if building with
ENABLE_SECURITY=offandRCUTILS_REPORT_ERROR_HANDLING_ERRORSset, the error string set inconfigure_qos_security()is always printed out on any downstream override.