Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Detect incompatible types from incompatible QoS callbacks #436

Open
wants to merge 4 commits into
base: rolling
Choose a base branch
from
Open

Detect incompatible types from incompatible QoS callbacks #436

Changes from 1 commit
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
3d59889
Implement inconsistent topic.
clalancette Dec 1, 2022
984065a
Rename RMW type name to "incompatible type".
clalancette Jan 17, 2023
35f5797
Detect incompatible types from incompatible QoS callbacks
allenh1 Feb 16, 2023
a930002
Clarify reason for special handling for inconsistent topic notification
allenh1 Feb 23, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Clarify reason for special handling for inconsistent topic notification 
Co-authored-by: eboasson <eb@ilities.com>
  • Loading branch information
@allenh1 @eboasson
allenh1 and eboasson authored Feb 23, 2023
commit a9300024262d6c9cf97476628287c65c286a4cac
2 changes: 1 addition & 1 deletion rmw_cyclonedds_cpp/src/rmw_node.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -515,7 +515,7 @@ MAKE_DDS_EVENT_CALLBACK_FN(sample_lost, SAMPLE_LOST)
MAKE_DDS_EVENT_CALLBACK_FN(liveliness_changed, LIVELINESS_CHANGED)

/**
* Because the inconsistent topic is not handled correctly in CycloneDDS,
* Because the inconsistent topic is not raised by CycloneDDS when a reader/writer fail to match because of differing type definitions
* this callback is signalled via the incompatible qos handlers
*/
// MAKE_DDS_EVENT_CALLBACK_FN(inconsistent_topic, INCONSISTENT_TOPIC)
Expand Down