Support RMW_EVENT_MESSAGE_LOST #169
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Yadunund <[email protected]>
clalancette
approved these changes
May 16, 2024
There was a problem hiding this comment.
This generally looks OK to me.
I will say that I have some misgivings about adding this. It seems kind of fragile, and I worry that we'll receive this event more than we expect. But there are no concrete problems I see, so I think we should put this in and see what happens.
Yadunund
added a commit
that referenced
this pull request
May 17, 2024
* Namespace Signed-off-by: Yadunund <[email protected]> * More namespacing Signed-off-by: Yadunund <[email protected]> * Check for lost messages in sub_data_handler (#169) Signed-off-by: Yadunund <[email protected]> * Address feedback Signed-off-by: Yadunund <[email protected]> --------- Signed-off-by: Yadunund <[email protected]> Signed-off-by: Yadunund <[email protected]> Signed-off-by: Yadunund <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR brings support for
RMW_EVENT_MESSAGE_LOST.It's best to test with ros2/demos#679.
Run the
message_lost_talkernode to publish at 1000Hz. See https://github.com/ros2/demos/tree/rolling/quality_of_service_demo#message-lost-status-event-demo for more details.Also removes unused variables from #103