Fix how total_count and total_count_change are calculated for matched events #287
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Yadunund <[email protected]>
Signed-off-by: Yadunund <[email protected]>
Yadunund
force-pushed
the
yadu/fix_matched_events
branch
from
e143578 to
9dece91
Compare
Yadunund
changed the title
ahcorde
approved these changes
Sep 27, 2024
YuanYuYuan
pushed a commit
to ZettaScaleLabs/rmw_zenoh
that referenced
this pull request
Sep 30, 2024
… events (ros2#287) * Fix how total_count and change are calculated Signed-off-by: Yadunund <[email protected]> * Ensure key expressions match Signed-off-by: Yadunund <[email protected]> --------- Signed-off-by: Yadunund <[email protected]>
imstevenpmwork
pushed a commit
to ZettaScaleLabs/rmw_zenoh
that referenced
this pull request
Sep 30, 2024
… events (ros2#287) * Fix how total_count and change are calculated Signed-off-by: Yadunund <[email protected]> * Ensure key expressions match Signed-off-by: Yadunund <[email protected]> --------- Signed-off-by: Yadunund <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
RCL tests expect
total_countandtotal_count_changeto only be incremented when new matches are found. Previously I was also incrementing them when matches were lost.current_count_changeneeds to beint32_tas seen here.Also added API to
remove_qos_event_callbacksbut this is just to clean up memory and does not fix the test expecations.With these changes, I am getting
rclcpp/test_qos_eventsto pass with this PR ros2/rclcpp#2626