Rename guid in liveliness_utils to keyexpr_hash.

[clalancette]

This more clearly reflect what it is, which is a
hash of the keyexpression that is used to index into various maps.

FYI @ahcorde and @Yadunund . I think this more accurately reflects what this particular data is used for, and helps (at least in my mind) to clear up some confusion about the "real" GID that we need to return from get_entities_info_by_topic.

Going forward, what I think we should do is the following:

1. Close Align on Transport GID and Liveliness GUID #148 , because there is really no direct relationship between those things.
2. Close Align on Transport GID and Liveliness GUID #291 (since it is attempting to implement Align on Transport GID and Liveliness GUID #148).
3. Fix get_entities_info_by_topic is not setting gid #290 by getting the GID from https://github.com/ros2/rmw_zenoh/blob/rolling/rmw_zenoh_cpp/src/detail/rmw_publisher_data.hpp#L74 in this line (there is probably some support work that needs to be done to enable access to that structure).

What do you think? Does that make sense?

[ahcorde]

ros2.repos

rmw_zenoh/yadu/raii-service

• rmw_zenoh commit: a43b861

ROS Package	Failing test name	Failing test output
rcl	None	None
rcl_action	None	None
rcl_lifecycle	None	None
rcl_yaml_param	None	None
rclcpp	test_intra_process_manager	Failed (Check logs)
rclcpp	test_node_interfaces__node_graph	Failed (Check logs)
rclcpp	test_publisher	Failed (Check logs)
rclcpp	test_events_executor	Timeout (Check logs)
rclcpp_action	None	None
rclcpp_components	None	None
rclcpp_lifecycle	None	-
rmw_zenoh_cpp	None	None
test_cli	None	None
test_cli_remap	test_cli_remapping	TBD

[ahcorde]

@Yadunund are you fine with this change ?

[clalancette]

@Yadunund are you fine with this change ?

Let's hold off on this one; I'm working on another change (which will probably include some parts of this), that I think will solve this entire problem.

[clalancette]

Closing in favor of #298