Additional fixes for yadu/raii-client. #304
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Chris Lalancette <[email protected]>
Yadunund
approved these changes
Oct 29, 2024
| std::move(request_type_support), | ||
| std::move(response_type_support) | ||
| }); | ||
| duplicate_pointers.push_back(client_data); |
There was a problem hiding this comment.
Why do we store the instantiated client_data ptr in this vector?
There was a problem hiding this comment.
If we didn't do this, then we could conceivably get the same address over and over again. Consider the case where we have the pointer 0x1 in deleted_clients. The first call to new ClientData might return 0x1. At that point, we'd detect that this is in deleted_clients, and loop around again. But right before we make the second call to new ClientData, we drop the reference to the old one, at which point it may be freed. At that point the allocator might decide to give us address 0x1 again, and we'd never make any progress here.
By holding all of the shared_ptr in a vector like this, we guarantee that the allocator will give us a new address. And then at the end of the function, when std::vector goes out of scope, we'll free all of them.
Yadunund
requested changes
Oct 29, 2024
Co-authored-by: yadunund <[email protected]> Signed-off-by: Chris Lalancette <[email protected]>
Signed-off-by: Chris Lalancette <[email protected]>
Yadunund
approved these changes
Oct 31, 2024
clalancette
added a commit
that referenced
this pull request
Nov 8, 2024
* Additional fixes for yadu/raii-client. Signed-off-by: Chris Lalancette <[email protected]> * Apply suggestions from code review Co-authored-by: yadunund <[email protected]> Signed-off-by: Chris Lalancette <[email protected]> * Fixups. Signed-off-by: Chris Lalancette <[email protected]> --------- Signed-off-by: Chris Lalancette <[email protected]> Co-authored-by: yadunund <[email protected]>
clalancette
added a commit
that referenced
this pull request
Nov 12, 2024
* Additional fixes for yadu/raii-client. Signed-off-by: Chris Lalancette <[email protected]> * Apply suggestions from code review Co-authored-by: yadunund <[email protected]> Signed-off-by: Chris Lalancette <[email protected]> * Fixups. Signed-off-by: Chris Lalancette <[email protected]> --------- Signed-off-by: Chris Lalancette <[email protected]> Co-authored-by: yadunund <[email protected]>
clalancette
pushed a commit
that referenced
this pull request
Nov 12, 2024
* Make ClientData thread-safe * Handle queries in flight * Address some feedback * Fix service client type check * fix tracking of num in flight without UB * Additional fixes for yadu/raii-client. (#304) * Additional fixes for yadu/raii-client. * Apply suggestions from code review * Fixups. * Fix -Wnon-pod-varargs * Make PublisherData::copy_gid have the same signatures as others. This just makes it more consistent with the rest of the APIs. * Add api to init client * Vastly simplify handling of in-flight ClientData. We basically use the pointer as a key to lookup the shared_ptr, and then always use the shared_ptr. That ensures that even if the pointer was dropped from the node while the client callback is operating, it will still be valid and won't be destroyed until that method returns. Signed-off-by: Yadunund <[email protected]> Signed-off-by: Chris Lalancette <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.