Recycle serialization buffers on transmission #342
+203
−16
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The aim of this pull request is to fix high latency for relatively large topics (e.g. 1 MB dd82e84
401016c
401016c + eed223a
|
fuzzypixelz
force-pushed
the
buffer-pool
branch
from
16df6fe to
401016c
Compare
fuzzypixelz
changed the title
|
All right, now that we've merged in #327 , we can consider this one. Please rebase this onto the latest, then we can do a full review of it. Until then, I'll mark it as a draft. |
fuzzypixelz
force-pushed
the
buffer-pool
branch
from
401016c to
62cb09b
Compare
Merged
fuzzypixelz
force-pushed
the
buffer-pool
branch
2 times, most recently
from
068cf50 to
21006d0
Compare
ahcorde
requested changes
Dec 19, 2024
fuzzypixelz
force-pushed
the
buffer-pool
branch
2 times, most recently
from
7ca544b to
bb6fd88
Compare
There was a formatting error from my IDE. I've restored the files and manually re-applied the patches. |
fuzzypixelz
force-pushed
the
buffer-pool
branch
4 times, most recently
from
515c43a to
8dd9bf5
Compare
Adds a bounded LIFO buffer pool in the context to reuse buffers allocated on serialization. The aim is not (only) to avoid the overhead of dynamic allocation but rather to enhance the cache locality of serialization buffers.
fuzzypixelz
force-pushed
the
buffer-pool
branch
from
8dd9bf5 to
bcc36a1
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds a LIFO buffer pool in the context to reuse buffers allocated on serialization. The aim is not (only) to avoid the overhead of dynamic allocation but rather to enhance the cache locality of serialization buffers.