Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove ZenohSession since it's not used now. #348

Merged
merged 1 commit into from
Dec 19, 2024
Merged

Remove ZenohSession since it's not used now. #348

merged 1 commit into from
Dec 19, 2024

Conversation

evshary
Copy link
Contributor

@evshary evshary commented Dec 19, 2024

Since we are using zenoh-cpp now, the class ZenohSession wrapper is not used anymore. I think it was missed while migrating.

@evshary evshary mentioned this pull request Dec 19, 2024
Draft
@YuanYuYuan
Copy link
Contributor

Hi @evshary, we still need it since we want to z_close the session if it's the last holder. Otherwise, we need to customize the std::shared_ptr deleter.

ahcorde
ahcorde approved these changes Dec 19, 2024
View reviewed changes
Copy link
Contributor

@ahcorde ahcorde left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The class is never instantiated, I think it's safe to remove this

clalancette
clalancette approved these changes Dec 19, 2024
View reviewed changes
Copy link
Collaborator

@clalancette clalancette left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, agreed, we don't need this anymore.

@ahcorde ahcorde merged commit 49a34bf into ros2:rolling Dec 19, 2024
6 checks passed
@evshary evshary deleted the remove_obsolete_code branch December 19, 2024 16:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ahcorde ahcorde ahcorde approved these changes

@clalancette clalancette clalancette approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@evshary @YuanYuYuan @clalancette @ahcorde