Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Fix PR #70] Instantiate new topic data for cache #75

Merged
merged 1 commit into from
Dec 2, 2023

Conversation

Yadunund
Copy link
Member

@Yadunund Yadunund commented Dec 2, 2023

Undo 357f658 as part of #70 (comment). We need to instantiate a new TopicDataPtr as the topic_map_data tracks the pub/sub count for a specific node so using the same shared_ptr would lead to incorrect tracking in graph_topics_ which keeps track of the count across the entire graph.

@Yadunund Yadunund changed the title [Fix PR #70]Instantiate new topic data for cache [Fix PR #70] Instantiate new topic data for cache Dec 2, 2023
@Yadunund Yadunund merged commit beb9fd8 into rolling Dec 2, 2023
5 checks passed
@Yadunund Yadunund deleted the yadu/fix_pr#70 branch December 2, 2023 11:22
Yadunund added a commit that referenced this pull request Jan 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant