Skip to content

Update Creating-Launch-Files.rst #5396

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: humble
Choose a base branch
from
Open

Conversation

andanders
Copy link

how to get launch file included in the build.
The tutorial does not show how to do this. As a result the command in the tutorial ros2 launch <package_name> <launch_file_name> does not work.

how to get launch file included in the build

Signed-off-by: andanders <[email protected]>
@christophebedard
Copy link
Member

Thanks for the PR. I agree that something is missing in this section, but I don't think we should add this here. This section calls ros2 launch with the path to the launch file, instead of the package name and the launch file name: no package is involved.

There is a note below about using ros2 launch <package_name> <launch_file_name>. It refers to the "Creating a package" tutorial, which is useful to explain how to create packages, but it indeed doesn't explain how to make a launch file part of a package so that it can be found with ros2 launch <package_name> <launch_file_name>. This is explained in the "Integrating launch files into ROS 2 packages" tutorial, more specifically in the "Creating the structure to hold launch files" section. I think the note should link to this section. Could you make this change?

Also, could you instead target the rolling branch instead of the humble branch? Then we can apply the change to other branches, including humble.

@andanders
Copy link
Author

Hi Christophe, the other tutorial you mention uses Glob to copy all files, so my specific example in this PR is redundant.
Since the tutorial already exists I feel that this PR is irrelevant. I will close it if you agree.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants