Skip to content

Subordinate nodes note for Kilted Kaiju. #5426

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 2 commits into
base: rolling
Choose a base branch
from
Open

Subordinate nodes note for Kilted Kaiju. #5426

wants to merge 2 commits into from

Conversation

fujitatomoya
Copy link
Collaborator

aligns with ros2/rclcpp#2830

@fujitatomoya fujitatomoya self-assigned this Apr 30, 2025
fujitatomoya
fujitatomoya commented Apr 30, 2025
View reviewed changes
Copy link
Collaborator Author

@fujitatomoya fujitatomoya left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@christophebedard can you review this?

@github-actions GitHub Actions
Copy link

github-actions bot commented Apr 30, 2025 •
edited
Loading

HTML artifacts: https://github.com/ros2/ros2_documentation/actions/runs/14782965745/artifacts/3046838243.

To view the resulting site:

  1. Click on the above link to download the artifacts archive
  2. Extract it
  3. Open html-artifacts-5426/index.html in your favorite browser

@christophebedard christophebedard added the backport-all backport at reviewers discretion; from rolling to all versions label Apr 30, 2025
kscottz
kscottz requested changes May 1, 2025
View reviewed changes
Copy link
Collaborator

@kscottz kscottz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would like just a smidge more context here for less versed developers.

@christophebedard christophebedard mentioned this pull request May 1, 2025
Open
4 tasks
@fujitatomoya
Copy link
Collaborator Author

@kscottz can you review the latest fix?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@christophebedard christophebedard christophebedard approved these changes

@kscottz kscottz kscottz requested changes

Assignees

@fujitatomoya fujitatomoya

Labels
backport-all backport at reviewers discretion; from rolling to all versions
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@fujitatomoya @kscottz @christophebedard