-
Notifications
You must be signed in to change notification settings - Fork 43
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Run relevant test_tracetools tests with all instrumented rmw impls #116
Run relevant test_tracetools tests with all instrumented rmw impls #116
Conversation
733836b
to
0cc18ef
Compare
ed1a245
to
0fdbb28
Compare
Huh, I guess the non-default So if I want the Rpr to stay green, I can't do |
0fdbb28
to
4e55210
Compare
I switched to just @fujitatomoya can you take another look? |
4e55210
to
bfd7b27
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I've left a couple of thoughts inline.
Besides that, do you have an idea of the impact on testing time? We are going from 5 tests to 15 here, so I just want to make sure this isn't adding a ton of time.
bfd7b27
to
f3a7a6b
Compare
Local GitHub CI (which runs tests sequentially IIRC) only has Cyclone DDS and Fast DDS, so 2 out of 3. For the whole
If I extrapolate to 2x the time difference (since this went from testing against 1 |
@ros-pull-request-builder retest this please |
Signed-off-by: Christophe Bedard <[email protected]>
f3a7a6b
to
c5223d2
Compare
@ros-pull-request-builder retest this please |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me with green CI.
This is equivalent to #116 but for Iron. Signed-off-by: Christophe Bedard <[email protected]>
This is equivalent to #116 but for Jazzy. Signed-off-by: Christophe Bedard <[email protected]>
This is equivalent to #116 but for Jazzy. Signed-off-by: Christophe Bedard <[email protected]>
This is equivalent to #116 but for Jazzy. Signed-off-by: Christophe Bedard <[email protected]>
The
test_tracetools
tracing tests only currently run using the defaultrmw
implementation. However, all "main"rmw
implementations are instrumented, so we should run the tests that coverrmw
instrumentation against all supported implementations.Requires #104 for CI to pass.