Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Run relevant test_tracetools tests with all instrumented rmw impls #116

Merged

Conversation

christophebedard
Copy link
Member

@christophebedard christophebedard commented Apr 19, 2024

The test_tracetools tracing tests only currently run using the default rmw implementation. However, all "main" rmw implementations are instrumented, so we should run the tests that cover rmw instrumentation against all supported implementations.

Requires #104 for CI to pass.

@christophebedard christophebedard self-assigned this Apr 19, 2024
@christophebedard christophebedard force-pushed the christophebedard/test-tracetools-multi-rmw branch from 733836b to 0cc18ef Compare April 19, 2024 23:06
@christophebedard christophebedard marked this pull request as ready for review April 23, 2024 16:04
@christophebedard christophebedard force-pushed the christophebedard/test-tracetools-multi-rmw branch 2 times, most recently from ed1a245 to 0fdbb28 Compare April 25, 2024 21:10
@christophebedard
Copy link
Member Author

Huh, I guess the non-default rmw implementations are not available for the Rpr job: https://build.ros2.org/job/Rpr__ros2_tracing__ubuntu_noble_amd64/51/cmake/new/

So if I want the Rpr to stay green, I can't do message(WARNING ...).

@christophebedard christophebedard force-pushed the christophebedard/test-tracetools-multi-rmw branch from 0fdbb28 to 4e55210 Compare April 25, 2024 22:20
@christophebedard
Copy link
Member Author

So if I want the Rpr to stay green, I can't do message(WARNING ...).

I switched to just message(...) and now the Rpr job is green.

@fujitatomoya can you take another look?

Copy link
Contributor

@clalancette clalancette left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've left a couple of thoughts inline.

Besides that, do you have an idea of the impact on testing time? We are going from 5 tests to 15 here, so I just want to make sure this isn't adding a ton of time.

test_tracetools/package.xml Show resolved Hide resolved
test_tracetools/CMakeLists.txt Show resolved Hide resolved
@christophebedard christophebedard force-pushed the christophebedard/test-tracetools-multi-rmw branch from bfd7b27 to f3a7a6b Compare June 18, 2024 20:53
@christophebedard
Copy link
Member Author

Besides that, do you have an idea of the impact on testing time? We are going from 5 tests to 15 here, so I just want to make sure this isn't adding a ton of time.

Local GitHub CI (which runs tests sequentially IIRC) only has Cyclone DDS and Fast DDS, so 2 out of 3. For the whole test_tracetools package:

  1. Before: 42.6 seconds
  2. After: 55.2 seconds

If I extrapolate to 2x the time difference (since this went from testing against 1 rmw implementation to 2 implementations), we'd get ~67.8 seconds with a third rmw implementation. Only 5 of the 13 tracing instrumentation tests get run against the list of 3 rmw implementations.

@christophebedard
Copy link
Member Author

@ros-pull-request-builder retest this please

@christophebedard christophebedard force-pushed the christophebedard/test-tracetools-multi-rmw branch from f3a7a6b to c5223d2 Compare June 19, 2024 14:54
@christophebedard
Copy link
Member Author

@ros-pull-request-builder retest this please

Copy link
Contributor

@clalancette clalancette left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me with green CI.

@christophebedard
Copy link
Member Author

  • Linux Build Status
  • Linux-aarch64 Build Status
  • Linux-rhel Build Status
  • Windows Build Status

@christophebedard christophebedard merged commit 63f060e into rolling Jun 21, 2024
7 of 9 checks passed
@christophebedard christophebedard deleted the christophebedard/test-tracetools-multi-rmw branch June 21, 2024 21:37
christophebedard added a commit that referenced this pull request Aug 22, 2024
This is equivalent to #116 but for Iron.

Signed-off-by: Christophe Bedard <[email protected]>
christophebedard added a commit that referenced this pull request Aug 22, 2024
This is equivalent to #116 but for Jazzy.

Signed-off-by: Christophe Bedard <[email protected]>
christophebedard added a commit that referenced this pull request Aug 22, 2024
This is equivalent to #116 but for Jazzy.

Signed-off-by: Christophe Bedard <[email protected]>
christophebedard added a commit that referenced this pull request Aug 26, 2024
This is equivalent to #116 but for Jazzy.

Signed-off-by: Christophe Bedard <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants