replace removeprefix with string slicing. #953
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Tomoya Fujita <[email protected]>
fujitatomoya
commented
Dec 12, 2024
clalancette
approved these changes
Dec 12, 2024
|
Pulls: #953
|
|
I really do not think the following access violation is generated by this PR. --- stderr: test_launch_ros
01:30:33 Windows fatal exception: access violation
01:30:33
01:30:33 Thread 0x00002ad4 (most recent call first):
01:30:33 File "C:\ci\ws\install\Lib\site-packages\rclpy\executors.py", line 718 in _wait_for_ready_callbacks
01:30:33 File "C:\ci\ws\install\Lib\site-packages\rclpy\executors.py", line 814 in wait_for_ready_callbacks
01:30:33 File "C:\ci\ws\install\Lib\site-packages\rclpy\executors.py", line 844 in _spin_once_impl
01:30:33 File "C:\ci\ws\install\Lib\site-packages\rclpy\executors.py", line 860 in spin_once
01:30:33 File "C:\ci\ws\install\Lib\site-packages\launch_ros\ros_adapters.py", line 77 in _run
01:30:33 File "C:\Python38\lib\threading.py", line 870 in run
01:30:33 File "C:\Python38\lib\threading.py", line 932 in _bootstrap_inner
01:30:33 File "C:\Python38\lib\threading.py", line 890 in _bootstrapretry CI windows.
|
|
this is originally required for already released distros. @Mergifyio backport humble jazzy |
|
@Mergifyio backport humble jazzy |
✅ Backports have been created
|
mergify bot
pushed a commit
that referenced
this pull request
Dec 17, 2024
Signed-off-by: Tomoya Fujita <[email protected]> (cherry picked from commit 35d6abd)
fujitatomoya
added a commit
that referenced
this pull request
Dec 17, 2024
Signed-off-by: Tomoya Fujita <[email protected]> (cherry picked from commit 35d6abd) Co-authored-by: Tomoya Fujita <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes #909