Fix for failing unit tests

- Check for `storage_` is not nullptr since it could be called from destructor - Add `storage_->update_metadata(metadata_)` in `SequentialCompressionWriter::close()` Signed-off-by: Michael Orlov <[email protected]>
ros2 · Nov 6, 2022 · 294db35 · 294db35
1 parent 77662e5
commit 294db35
Show file tree

Hide file tree

Showing 2 changed files with 6 additions and 1 deletion.
diff --git a/rosbag2_compression/src/rosbag2_compression/sequential_compression_writer.cpp b/rosbag2_compression/src/rosbag2_compression/sequential_compression_writer.cpp
@@ -206,6 +206,9 @@ void SequentialCompressionWriter::close()
     stop_compressor_threads();
 
     finalize_metadata();
+    if (storage_) {
+      storage_->update_metadata(metadata_);
+    }
     metadata_io_->write_metadata(base_folder_, metadata_);
   }
 

diff --git a/rosbag2_cpp/src/rosbag2_cpp/writers/sequential_writer.cpp b/rosbag2_cpp/src/rosbag2_cpp/writers/sequential_writer.cpp
@@ -155,7 +155,9 @@ void SequentialWriter::close()
 
   if (!base_folder_.empty()) {
     finalize_metadata();
-    storage_->update_metadata(metadata_);
+    if (storage_) {
+      storage_->update_metadata(metadata_);
+    }
     metadata_io_->write_metadata(base_folder_, metadata_);
   }