Add update_metadata(BagMetadata) API for storage plugin interface
#1149
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- We need update_metadata(BagMetadata) API to be able to save BagMetadata inside each bag file, directly in SQLite DB or MCAP file. - update_metadata(BagMetadata) calling ones after creating storage object and second time just before destructing it. Signed-off-by: Michael Orlov <[email protected]>
MichaelOrlov
changed the title
update_metadata(BagMetadata) for storage plugins interfaceupdate_metadata(BagMetadata) API for storage plugins interface
MichaelOrlov
changed the title
update_metadata(BagMetadata) API for storage plugins interfaceupdate_metadata(BagMetadata) API for storage plugin interface
- Check for `storage_` is not nullptr since it could be called from destructor - Add `storage_->update_metadata(metadata_)` in `SequentialCompressionWriter::close()` Signed-off-by: Michael Orlov <[email protected]>
- Test that storage->update_metadata() called on writer open and during writer destruction. - Test that storage->update_metadata() calling with appropriate parameters when calling `bag_split()` Signed-off-by: Michael Orlov <[email protected]>
- Test that storage->update_metadata() called on writer open and during writer destruction. - Test that storage->update_metadata() calling with appropriate parameters when calling `bag_split()` Signed-off-by: Michael Orlov <[email protected]>
MichaelOrlov
force-pushed
the
morlov/add-update_metadata-api-for-storage-plugins
branch
from
a67be0d to
6f18793
Compare
MichaelOrlov
requested review from
emersonknapp and
jhdcs
and removed request for
a team
This was referenced Nov 8, 2022
|
Gist: https://gist.githubusercontent.com/MichaelOrlov/e5b179b77a8b80102736bf330fa8fa3f/raw/ee348d57a834af87ed47ffd16a48fc6a75ec5de1/ros2.repos
|
|
Re-run CI after rebasing and fixing merge conflicts
|
delete-merged-branch
bot
deleted the
morlov/add-update_metadata-api-for-storage-plugins
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We need
update_metadata(BagMetadata)API to be able to saveBagMetadatadirectly inside each bag file, in SQLite DB or MCAP file.update_metadata(BagMetadata) calling ones after creating storage object and second time just before destructing it.
Also added caching for
SqliteStorage::get_metadata()as follow up for Don't reopen file for every seek if we don't have to. Search directionally for the correct file #1117Note: Real saving of bag metadata in SQLite DB will be done in separate PR after Store DB schema versioning in .db3 files #1108. We need to bring this API first to unblock inform storage plugin about message-level compression #1144
Relates:
Signed-off-by: Michael Orlov [email protected]