-
Notifications
You must be signed in to change notification settings - Fork 253
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[jazzy] Add "--sort" CLI option to the "ros2 bag info" command (backport #1804) #1838
Conversation
Cherry-pick of 25304dd has failed:
To fix up this pull request, you can check it out locally. See documentation: https://docs.github.com/en/pull-requests/collaborating-with-pull-requests/reviewing-changes-in-pull-requests/checking-out-pull-requests-locally |
* sort info output by topic name Signed-off-by: Soenke Prophet <[email protected]> * add missing imports Signed-off-by: Soenke Prophet <[email protected]> * add sorting to service topics and remove sorting option by serialization format Signed-off-by: Soenke Prophet <[email protected]> * add CLI option for sorting output and move sorting methods to enum Signed-off-by: Soenke Prophet <[email protected]> * add sorting by name to topic only option of info output Signed-off-by: Soenke Prophet <[email protected]> * move InfoSortingMethod and generate sorted idx functions to seprate files; move ServiceInformation and ServiceMetadata struct to storage package for clear include structure Signed-off-by: Soenke Prophet <[email protected]> * move ServiceInformation struct to its own header file and rename to ServiceEventInformation; replace if-else by switch-case for differantiating between sorting methods; bugfix sorting method from string resolution and service info verbose not being sorted Signed-off-by: Soenke Prophet <[email protected]> * add test-cases for sorted info output Signed-off-by: Soenke Prophet <[email protected]> * Fix linker issues - Add missing const qualifier for the generate_sorted_idx(..) version with rosbag2_cpp::rosbag2_service_info_t - Small cleanups Signed-off-by: Michael Orlov <[email protected]> * Regenerate pyi stub files Signed-off-by: Michael Orlov <[email protected]> * Small nitpick for using const reference in the for loop Signed-off-by: Michael Orlov <[email protected]> --------- Signed-off-by: Soenke Prophet <[email protected]> Signed-off-by: Michael Orlov <[email protected]> Co-authored-by: Soenke Prophet <[email protected]> Co-authored-by: Michael Orlov <[email protected]>
4e5e021
to
3de438a
Compare
- On Jazzy parameters in the "format_bag_meta_data(..)" has a different order. The "sizes" at the end. Changed calling function accordingly. Signed-off-by: Michael Orlov <[email protected]>
- Add default value for newly added argument "sorting_method" in "print_output(..)" and "print_output_verbose(..)" Signed-off-by: Michael Orlov <[email protected]>
3de438a
to
27a280e
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I made this PR API/ABI compatible by adding a default value for the newly added argument "sorting_method" in
"print_output(..)" and "print_output_verbose(..)"
Pulls: #1838 |
This PR adds the "--sort" CLI option to the "ros2 bag info" command. With "--sort" CLI option user will be able to sort topics and services by name, topic type or number of recorded messages.
ros2 bag info
#1797This is an automatic backport of pull request #1804 done by [Mergify](https://mergify.com).