Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add debug information for flaky can_record_again_after_stop test #1871

Merged
merged 1 commit into from
Dec 2, 2024
Merged

Add debug information for flaky can_record_again_after_stop test #1871

merged 1 commit into from
Dec 2, 2024

Conversation

MichaelOrlov
Copy link
Contributor

This PR adds debug output for flaky rosbag2_transport::can_record_again_after_stop test.

Some times can_record_again_after_stop test fail with error messages like

/tmp/ws/src/rosbag2/rosbag2_transport/test/rosbag2_transport/test_record.cpp:167
Value of: recorded_messages
Expected: has a size that is equal to 4
  Actual: { (ptr = 0x7f429c0023e0, value = 64-byte object <60-23 00-9C 42-7F 00-00 F0-22 00-9C 42-7F 00-00 98-12 B6-45 47-6C 0A-18 D1-BA B5-45 47-6C 0A-18 10-24 00-9C 42-7F 00-00 0D-00 00-00 00-00 00-00 2F-73 74-72 69-6E 67-5F 74-6F 70-69 63-00 00-00>), (ptr = 0x7f429c003670, value = 64-byte object <F0-1E 00-9C 42-7F 00-00 70-18 00-9C 42-7F 00-00 BE-31 B3-48 47-6C 0A-18 5A-B9 B2-48 47-6C 0A-18 A0-36 00-9C 42-7F 00-00 0D-00 00-00 00-00 00-00 2F-73 74-72 69-6E 67-5F 74-6F 70-69 63-00 00-00>), (ptr = 0x7f429c003870, value = 64-byte object <10-37 00-9C 42-7F 00-00 70-33 00-9C 42-7F 00-00 D9-94 DA-4B 47-6C 0A-18 0D-7A DA-4B 47-6C 0A-18 A0-38 00-9C 42-7F 00-00 0D-00 00-00 00-00 00-00 2F-73 74-72 69-6E 67-5F 74-6F 70-69 63-00 00-00>), (ptr = 0x55695db64300, value = 64-byte object <50-D8 B5-5D 69-55 00-00 30-7C 9D-5D 69-55 00-00 3D-A9 DA-4B 47-6C 0A-18 0D-7A DA-4B 47-6C 0A-18 30-43 B6-5D 69-55 00-00 0D-00 00-00 00-00 00-00 2F-73 74-72 69-6E 67-5F 74-6F 70-69 63-00 00-00>), (ptr = 0x55695d9b0390, value = 64-byte object <00-05 9B-5D 69-55 00-00 10-F3 8F-5D 69-55 00-00 B2-0B D8-4E 47-6C 0A-18 33-7B D7-4E 47-6C 0A-18 C0-03 9B-5D 69-55 00-00 0D-00 00-00 00-00 00-00 2F-73 74-72 69-6E 67-5F 74-6F 70-69 63-00 00-00>) }, whose size 5 doesn't match


/tmp/ws/src/rosbag2/rosbag2_transport/test/rosbag2_transport/test_record.cpp:180
Value of: string_messages
Expected: has a size that is equal to 4
  Actual: { (ptr = 0x55695d7b3b70, value = 384-byte object <80-3B 7B-5D 69-55 00-00 0C-00 00-00 00-00 00-00 48-65 6C-6C 6F-20 77-6F 72-6C 64-21 00-7F 00-00 A0-3B 7B-5D 69-55 00-00 0C-00 00-00 00-00 00-00 48-65 6C-6C 6F-20 77-6F 72-6C 64-21 00-00 00-00 ... C0-3C 7B-5D 69-55 00-00 0C-00 00-00 00-00 00-00 48-65 6C-6C 6F-27 77-6F 72-6C 64-21 00-00 00-00 E0-3C 7B-5D 69-55 00-00 0C-00 00-00 00-00 00-00 48-65 6C-6C 6F-22 77-6F 72-6C 64-21 00-00 00-00>), (ptr = 0x55695d720600, value = 384-byte object <10-06 72-5D 69-55 00-00 0C-00 00-00 00-00 00-00 48-65 6C-6C 6F-20 77-6F 72-6C 64-21 00-33 34-00 30-06 72-5D 69-55 00-00 0C-00 00-00 00-00 00-00 48-65 6C-6C 6F-20 77-6F 72-6C 64-21 00-00 00-00 ... 50-07 72-5D 69-55 00-00 0C-00 00-00 00-00 00-00 48-65 6C-6C 6F-27 77-6F 72-6C 64-21 00-00 00-00 70-07 72-5D 69-55 00-00 0C-00 00-00 00-00 00-00 48-65 6C-6C 6F-22 77-6F 72-6C 64-21 00-00 00-00>), (ptr = 0x55695dba00b0, value = 384-byte object <C0-00 BA-5D 69-55 00-00 0C-00 00-00 00-00 00-00 48-65 6C-6C 6F-20 77-6F 72-6C 64-21 00-21 00-00 E0-00 BA-5D 69-55 00-00 0C-00 00-00 00-00 00-00 48-65 6C-6C 6F-20 77-6F 72-6C 64-21 00-00 00-00 ... 00-02 BA-5D 69-55 00-00 0C-00 00-00 00-00 00-00 48-65 6C-6C 6F-27 77-6F 72-6C 64-21 00-00 00-00 20-02 BA-5D 69-55 00-00 0C-00 00-00 00-00 00-00 48-65 6C-6C 6F-22 77-6F 72-6C 64-21 00-00 00-00>), (ptr = 0x55695db9e0b0, value = 384-byte object <C0-E0 B9-5D 69-55 00-00 0C-00 00-00 00-00 00-00 48-65 6C-6C 6F-20 77-6F 72-6C 64-21 00-00 00-00 E0-E0 B9-5D 69-55 00-00 0C-00 00-00 00-00 00-00 48-65 6C-6C 6F-20 77-6F 72-6C 64-21 00-00 00-00 ... 00-E2 B9-5D 69-55 00-00 0C-00 00-00 00-00 00-00 48-65 6C-6C 6F-27 77-6F 72-6C 64-21 00-00 00-00 20-E2 B9-5D 69-55 00-00 0C-00 00-00 00-00 00-00 48-65 6C-6C 6F-22 77-6F 72-6C 64-21 00-00 00-00>), (ptr = 0x55695d6669b0, value = 384-byte object <C0-69 66-5D 69-55 00-00 0C-00 00-00 00-00 00-00 48-65 6C-6C 6F-20 77-6F 72-6C 64-21 00-21 00-00 E0-69 66-5D 69-55 00-00 0C-00 00-00 00-00 00-00 48-65 6C-6C 6F-20 77-6F 72-6C 64-21 00-00 00-00 ... 00-6B 66-5D 69-55 00-00 0C-00 00-00 00-00 00-00 48-65 6C-6C 6F-27 77-6F 72-6C 64-21 00-00 00-00 20-6B 66-5D 69-55 00-00 0C-00 00-00 00-00 00-00 48-65 6C-6C 6F-22 77-6F 72-6C 64-21 00-00 00-00>) }, whose size 5 doesn't match

Link to the failing rpr job https://build.ros2.org/job/Jpr__rosbag2__ubuntu_noble_amd64/66/testReport/junit/rosbag2_transport/RecordIntegrationTestFixture/can_record_again_after_stop/

@MichaelOrlov MichaelOrlov marked this pull request as ready for review December 2, 2024 02:36
@MichaelOrlov MichaelOrlov force-pushed the morlov/add-debug-for-can_record_again_after_stop branch from 722b40d to 1121d1d Compare December 2, 2024 02:38
@MichaelOrlov
Copy link
Contributor Author

@ros-pull-request-builder retest this please

@christophebedard
Copy link
Member

christophebedard commented Dec 2, 2024 •
edited
Loading

Link to the failing rpr job https://build.ros2.org/job/Jpr__rosbag2__ubuntu_noble_amd64/66/testReport/junit/rosbag2_transport/RecordIntegrationTestFixture/can_record_again_after_stop/

The job you linked to is a Jpr job, so Jazzy, but this PR is targeting Rolling. Is this needed on Rolling, or should it target Jazzy instead?

@MichaelOrlov
Copy link
Contributor Author

@christophebedard There is No need to retarget to Jazzy. The same issue reproduces on rolling as well.

christophebedard
christophebedard approved these changes Dec 2, 2024
View reviewed changes
Copy link
Member

@christophebedard christophebedard left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good to me with green CI

@MichaelOrlov
Copy link
Contributor Author

Pulls: #1871
Gist: https://gist.githubusercontent.com/MichaelOrlov/7ae23b62967ca62396d3dd268479689a/raw/1ccb3561d6bc09d16485af3f01af5cf5a7f38628/ros2.repos
BUILD args: --packages-above-and-dependencies rosbag2_transport rosbag2_test_common
TEST args: --packages-above rosbag2_transport rosbag2_test_common
ROS Distro: rolling
Job: ci_launcher
ci_launcher ran: https://ci.ros2.org/job/ci_launcher/14889

  • Linux Build Status
  • Linux-aarch64 Build Status
  • Linux-rhel Build Status
  • Windows Build Status

fujitatomoya
fujitatomoya approved these changes Dec 2, 2024
View reviewed changes
Copy link
Contributor

@fujitatomoya fujitatomoya left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks!

@MichaelOrlov
Copy link
Contributor Author

Two new warnings are in the StaticSingleThreadedExecutor and unrelated to the changes from this PR.

'rclcpp::executors::StaticSingleThreadedExecutor::StaticSingleThreadedExecutor': Use rclcpp::executors::SingleThreadedExecutor (compiling source file C:\ci\ws\src\ros2\rclcpp\rclcpp\test\rclcpp\executors\test_executors.cpp)`

@MichaelOrlov MichaelOrlov merged commit 4602b2c into rolling Dec 2, 2024
12 checks passed
@MichaelOrlov MichaelOrlov deleted the morlov/add-debug-for-can_record_again_after_stop branch December 2, 2024 23:57
@MichaelOrlov
Copy link
Contributor Author

https://github.com/Mergifyio backport jazzy

@mergify Mergify
Copy link

mergify bot commented Dec 3, 2024 •
edited
Loading

backport jazzy

✅ Backports have been created

mergify bot pushed a commit that referenced this pull request Dec 3, 2024
@MichaelOrlov @mergify
Add debug information for flaky can_record_again_after_stop test (#1871)
a6c1f85 
Signed-off-by: Michael Orlov <[email protected]>
(cherry picked from commit 4602b2c)
@mergify mergify bot mentioned this pull request Dec 3, 2024
Merged
MichaelOrlov added a commit that referenced this pull request Dec 3, 2024
@mergify @MichaelOrlov
Add debug information for flaky can_record_again_after_stop test (#1871…
1ae448c 
…) (#1874)

Signed-off-by: Michael Orlov <[email protected]>
(cherry picked from commit 4602b2c)

Co-authored-by: Michael Orlov <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@christophebedard christophebedard christophebedard approved these changes

@fujitatomoya fujitatomoya fujitatomoya approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@MichaelOrlov @christophebedard @fujitatomoya