-
Notifications
You must be signed in to change notification settings - Fork 47
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
Fix a number of warnings on Ubuntu 24.04. (#289)
* Fix a number of warnings on Ubuntu 24.04. In particular: 1. Get rid of the fallback path for argcompleter. It isn't necessary anymore since all versions of argcompleter support these, and it was confusing mypy. 2. Add in a proper Optional annotation. 3. Use the newer importlib_resources.file API when it is available. * Add in appropriate dependency on python3-argcomplete. Also do a minor refactoring of the dependencies while we are here. Signed-off-by: Chris Lalancette <[email protected]>
- Loading branch information
1 parent
0f1bc39
commit 73f1b0d
Showing
9 changed files
with
29 additions
and
64 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -10,13 +10,13 @@ | |
<author email="[email protected]">Morgan Quigley</author> | ||
<author>Mikael Arguedas</author> | ||
|
||
<depend>rclpy</depend> | ||
<depend>ros2cli</depend> | ||
|
||
<exec_depend>ament_index_python</exec_depend> | ||
<exec_depend>python3-lxml</exec_depend> | ||
<exec_depend>python3-argcomplete</exec_depend> | ||
<exec_depend>python3-cryptography</exec_depend> | ||
<exec_depend>python3-importlib-resources</exec_depend> | ||
<exec_depend>python3-lxml</exec_depend> | ||
<exec_depend>rclpy</exec_depend> | ||
<exec_depend>ros2cli</exec_depend> | ||
|
||
<test_depend>ament_copyright</test_depend> | ||
<test_depend>ament_flake8</test_depend> | ||
|
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters