add cyclonedds to the list of rmw using graph info topics #231
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Mikael Arguedas <[email protected]>
Codecov Report
@@ Coverage Diff @@
## master #231 +/- ##
=======================================
Coverage 76.84% 76.84%
=======================================
Files 23 23
Lines 609 609
Branches 53 53
=======================================
Hits 468 468
Misses 121 121
Partials 20 20
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
|
This fixed the failures at ros2/system_tests#408 (comment) Marking this as ready for review |
ruffsl
approved these changes
Jul 31, 2020
Arnatious
approved these changes
Aug 6, 2020
kyrofa
approved these changes
Aug 10, 2020
|
may need to be backported to foxy depending on ros2/ros2#999 |
|
This pull request has been mentioned on ROS Discourse. There might be relevant details there: https://discourse.ros.org/t/ros-2-tsc-meeting-minutes-2020-08-20/16063/1 |
mikaelarguedas
added a commit
to mikaelarguedas/sros2
that referenced
this pull request
Sep 2, 2020
Signed-off-by: Mikael Arguedas <[email protected]>
mikaelarguedas
added a commit
to mikaelarguedas/sros2
that referenced
this pull request
Sep 16, 2020
Signed-off-by: Mikael Arguedas <[email protected]>
mikaelarguedas
added a commit
that referenced
this pull request
Sep 16, 2020
Signed-off-by: Mikael Arguedas <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
To test if it fixes the issue of CI failing with cyclone and security from ros2/system_tests#408
Necessary since ros2/rmw_cyclonedds#145 particularily this bit https://github.com/ros2/rmw_cyclonedds/blob/3bfe094b60c1a3116b1f2c09c845a745fd240987/rmw_cyclonedds_cpp/src/rmw_node.cpp#L1026-L1035