add --no-daemon and --spin-time explanation in readme.
#307
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Tomoya Fujita <[email protected]>
fujitatomoya
commented
May 8, 2024
|
i think we want to backport this to jazzy at least. |
Signed-off-by: Tomoya Fujita <[email protected]>
mikaelarguedas
approved these changes
May 8, 2024
There was a problem hiding this comment.
👍 lgtm and agree to backport to jazzy as this bit of the tutorial alreay made it to the Jazzy branch: #296
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## rolling #307 +/- ##
========================================
Coverage 77.35% 77.35%
========================================
Files 25 25
Lines 627 627
Branches 66 66
========================================
Hits 485 485
Misses 121 121
Partials 21 21
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
|
@Mergifyio backport jazzy |
✅ Backports have been created
|
mergify bot
pushed a commit
that referenced
this pull request
May 8, 2024
* add `--no-daemon` and `--spin-time` explanation in readme. * increase `--spin-time` from 3 to 4 seconds based on CI. --------- Signed-off-by: Tomoya Fujita <[email protected]> (cherry picked from commit 1a4257d)
mikaelarguedas
pushed a commit
that referenced
this pull request
May 8, 2024
… (#308) * add `--no-daemon` and `--spin-time` explanation in readme. * increase `--spin-time` from 3 to 4 seconds based on CI. --------- Signed-off-by: Tomoya Fujita <[email protected]> (cherry picked from commit 1a4257d) Co-authored-by: Tomoya Fujita <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
address part of #306