Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Give more time to generate policies in tests #323

Merged
merged 1 commit into from
Jul 22, 2024

Conversation

ahcorde
Copy link
Contributor

@ahcorde ahcorde commented Jul 17, 2024

Related with this PR #321

I was playing with the linked flaky issue and my guess is that the policy is not generated because it required more time.

Signed-off-by: Alejandro Hernández Cordero <[email protected]>
Copy link

codecov bot commented Jul 17, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 88.94%. Comparing base (8a033c1) to head (454ab1b).

Additional details and impacted files
@@           Coverage Diff            @@
##           rolling     #323   +/-   ##
========================================
  Coverage    88.94%   88.94%           
========================================
  Files           24       24           
  Lines          615      615           
  Branches        64       64           
========================================
  Hits           547      547           
  Misses          50       50           
  Partials        18       18           
Flag Coverage Δ
unittests 88.94% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@ahcorde
Copy link
Contributor Author

ahcorde commented Jul 22, 2024

  • Linux Build Status
  • Linux-aarch64 Build Status
  • Linux-rhel Build Status
  • Windows Build Status

Copy link
Contributor

@clalancette clalancette left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not convinced that it will make a difference, but we can certainly try it and see if things improve.

@ahcorde ahcorde merged commit 22f9e97 into rolling Jul 22, 2024
7 checks passed
@ahcorde ahcorde deleted the ahcorde/rolling/test_generate_policy_no_nodes branch July 22, 2024 20:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants