-
Notifications
You must be signed in to change notification settings - Fork 30
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[WIP] 390 monthly email list #705
Conversation
Hey @mz99 thank you for your PR! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
How can I trigger the sending of the mails?
Have a look into a rake task that I used once: https://github.com/roschaefer/rundfunk-mitbestimmen/blob/master/backend/lib/tasks/mail.rake
I would also suggest to create some tests for the list of reasons under certain conditions.
backend/app/mailers/user_mailer.rb
Outdated
|
||
def monthly_news(user, reason) | ||
@user = user | ||
mail(to: @user.email, subject: "") |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Maybe build a subject line here?
<p> | ||
Welcome to another month's happenings with the new stuff this month: | ||
|
||
- There are 2 new features |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You could iterate over the list of reasons to contact the user and build a string here 👍
…funk-mitbestimmen into 390_monthly_email_list
Initial email template to get issue 390 rolling.
Would like feedback on my questions in #390 to proceed further.