Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[WIP] 390 monthly email list #705

Merged
merged 11 commits into from
Jul 27, 2018
Merged

Conversation

mz99
Copy link
Collaborator

@mz99 mz99 commented Jul 12, 2018

Initial email template to get issue 390 rolling.
Would like feedback on my questions in #390 to proceed further.

@roschaefer
Copy link
Owner

Hey @mz99 thank you for your PR!
You did everything correct regarding the branches of your PR! 😄
If the build server fails, look for lines coloured in red in the log output. I can see that e.g. our rubocop complaints about some code style issues. You can fix some of those automatically with bundle exec rubocop -a.

Copy link
Owner

@roschaefer roschaefer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

How can I trigger the sending of the mails?

Have a look into a rake task that I used once: https://github.com/roschaefer/rundfunk-mitbestimmen/blob/master/backend/lib/tasks/mail.rake

I would also suggest to create some tests for the list of reasons under certain conditions.


def monthly_news(user, reason)
@user = user
mail(to: @user.email, subject: "")
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe build a subject line here?

<p>
Welcome to another month's happenings with the new stuff this month:

- There are 2 new features
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You could iterate over the list of reasons to contact the user and build a string here 👍

@mz99 mz99 changed the title WIP 390 monthly email list [WIP] 390 monthly email list Jul 16, 2018
@mz99 mz99 merged commit ba899dc into roschaefer:master Jul 27, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants