Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace Rc<Vec<Val>> with Rc<[Val]> in interpreter #63

Open
samestep opened this issue Jul 24, 2023 · 0 comments
Open

Replace Rc<Vec<Val>> with Rc<[Val]> in interpreter #63

samestep opened this issue Jul 24, 2023 · 0 comments

Comments

@samestep
Copy link
Contributor

Currently the interpreter uses Rc<Vec<Val>> to hold arrays and tuples:

Array(Rc<Vec<Val>>), // assume all indices are `Fin`
Tuple(Rc<Vec<Val>>),

This is two layers of indirection rather than one; we should replace it with just Rc<[Val]>. The blocker is that ts-rs doesn't seem to currently support Rc<[T]>.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant