Merge branch '126-exception-handling-in-verify-event' into 'dev'

rethrow any errors while verifying events Closes #126 See merge request ergo/rosen-bridge/rosen-chains!155
rosen-bridge · Nov 25, 2024 · 4986335 · 4986335
2 parents 817d526 + 7528e4a
commit 4986335
Show file tree

Hide file tree

Showing 2 changed files with 6 additions and 8 deletions.
diff --git a/.changeset/neat-turkeys-cry.md b/.changeset/neat-turkeys-cry.md
@@ -0,0 +1,5 @@
+---
+'@rosen-chains/abstract-chain': patch
+---
+
+Rethrow any unexpected errors while verifying events
diff --git a/packages/abstract-chain/lib/AbstractChain.ts b/packages/abstract-chain/lib/AbstractChain.ts
@@ -253,15 +253,8 @@ abstract class AbstractChain<TxType> {
           `Event [${eventId}] is not valid, lock tx [${event.sourceTxId}] is not available in network`
         );
         return false;
-      } else if (
-        e instanceof FailedError ||
-        e instanceof NetworkError ||
-        e instanceof UnexpectedApiError
-      ) {
-        throw Error(`Skipping event [${eventId}] validation: ${e}`);
       } else {
-        this.logger.warn(`Event [${eventId}] validation failed: ${e}`);
-        return false;
+        throw Error(`Skipping event [${eventId}] validation: ${e}`);
       }
     }
   };