Skip to content

Commit

Permalink
Merge branch '481-ensure-a-consistent-version-of-the-types-node-npm-p…
Browse files Browse the repository at this point in the history
…ackage-is-used-across-all-packages' into 'dev'

Resolve "Ensure a consistent version of the @types/node npm package is used across all packages"

Closes #481

See merge request ergo/rosen-bridge/ui!402
  • Loading branch information
vorujack committed Dec 28, 2024
2 parents 5dc1b8f + ac25100 commit 936ec5d
Show file tree
Hide file tree
Showing 11 changed files with 36 additions and 51 deletions.
9 changes: 9 additions & 0 deletions .changeset/early-badgers-mate.md
Original file line number Diff line number Diff line change
@@ -0,0 +1,9 @@
---
'@rosen-ui/asset-calculator': patch
'@rosen-bridge/rosen-service': patch
'@rosen-bridge/watcher-app': patch
'@rosen-bridge/guard-app': patch
'@rosen-bridge/rosen-app': patch
---

Install a reliable and consistent version of the @types/node npm package
6 changes: 3 additions & 3 deletions .github/workflows/ci.yml
Original file line number Diff line number Diff line change
Expand Up @@ -19,7 +19,7 @@ jobs:
- name: Setup node
uses: actions/setup-node@v3
with:
node-version: 20
node-version: 20.18.1
cache: 'npm'

- run: npm ci
Expand All @@ -34,7 +34,7 @@ jobs:
strategy:
fail-fast: false
matrix:
node-version: [18, 20]
node-version: [20.18.1]
steps:
- uses: actions/checkout@v3

Expand All @@ -60,6 +60,6 @@ jobs:
- name: Run changeset to check versions
uses: actions/setup-node@v3
with:
node-version: 20
node-version: 20.18.1
cache: 'npm'
- run: npx @changesets/[email protected] status --since=origin/dev
4 changes: 2 additions & 2 deletions .github/workflows/release.yml
Original file line number Diff line number Diff line change
Expand Up @@ -14,7 +14,7 @@ jobs:
- name: Setup node
uses: actions/setup-node@v3
with:
node-version: 18
node-version: 20.18.1

- name: Install yaml2json
run: npm install -g yamljs
Expand Down Expand Up @@ -49,7 +49,7 @@ jobs:
strategy:
matrix:
os: [ubuntu-latest, macos-latest, windows-latest]
node-version: [18.x]
node-version: [20.18.1]
include:
- os: macos-latest
platform: macOS
Expand Down
2 changes: 1 addition & 1 deletion .gitlab-ci.yml
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
image: node:20.11.0
image: node:20.18.1

stages:
- installation
Expand Down
2 changes: 1 addition & 1 deletion .nvmrc
Original file line number Diff line number Diff line change
@@ -1 +1 @@
20.11.0
20.18.1
2 changes: 1 addition & 1 deletion apps/guard/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -35,7 +35,7 @@
"@rosen-ui/types": "^0.3.2",
"@tauri-apps/cli": "^1.4.0",
"@types/moment": "^2.13.0",
"@types/node": "20.2.5",
"@types/node": "^20.17.10",
"@types/react": "18.2.12",
"@types/react-copy-to-clipboard": "^5.0.5",
"@types/react-dom": "18.2.4",
Expand Down
2 changes: 1 addition & 1 deletion apps/rosen-service/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -32,7 +32,7 @@
},
"devDependencies": {
"@types/config": "^0.0.41",
"@types/node": "^20.11.0",
"@types/node": "^20.17.10",
"tsx": "^4.19.2",
"typescript": "^5.0.0"
}
Expand Down
2 changes: 1 addition & 1 deletion apps/rosen/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -65,7 +65,7 @@
},
"devDependencies": {
"@types/lodash-es": "^4.17.10",
"@types/node": "20.5.7",
"@types/node": "^20.17.10",
"@types/react": "18.2.12",
"@types/react-dom": "18.2.4",
"eslint": "8.42.0",
Expand Down
2 changes: 1 addition & 1 deletion apps/watcher/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -38,7 +38,7 @@
"@tauri-apps/cli": "^1.4.0",
"@types/lodash-es": "^4.17.11",
"@types/moment": "^2.13.0",
"@types/node": "20.2.5",
"@types/node": "^20.17.10",
"@types/react": "18.2.12",
"@types/react-dom": "18.2.4",
"eslint": "8.42.0",
Expand Down
52 changes: 14 additions & 38 deletions package-lock.json

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

4 changes: 2 additions & 2 deletions packages/asset-calculator/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -18,12 +18,12 @@
"type-check": "tsc --noEmit"
},
"devDependencies": {
"@types/node": "^20.11.9",
"@types/node": "^20.17.10",
"extensionless": "^1.9.6",
"typescript": "^5.1.6"
},
"engines": {
"node": ">=20.11.0"
"node": ">=20.18.1"
},
"dependencies": {
"@rosen-bridge/abstract-logger": "^1.0.0",
Expand Down

0 comments on commit 936ec5d

Please sign in to comment.