Feat: add toggle button group #133
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kelsos
reviewed
Oct 16, 2023
| @@ -6,22 +6,60 @@ export interface Props { | |||
| color?: ContextColorsType; | |||
| variant?: 'default' | 'outlined' | 'text'; | |||
| size?: 'sm' | 'lg'; | |||
| required?: boolean; | |||
| modelValue?: number | number[]; | |||
There was a problem hiding this comment.
hmm, at least in a few of the use-cases we have we use a custom value in buttons
So we would need to be able to replicate this here too.
There was a problem hiding this comment.
means we need to make it generic, and add value to the button component...
|
Also on some colors the selected item is a bit harder to distinguish, any change we could make it slightly more obvious? |
tewshi
force-pushed
the
feat-toggle-button-group
branch
2 times, most recently
from
b43634c to
9199892
Compare
Codecov Report
@@ Coverage Diff @@
## main #133 +/- ##
==========================================
+ Coverage 91.00% 91.12% +0.11%
==========================================
Files 39 39
Lines 6763 6849 +86
Branches 275 288 +13
==========================================
+ Hits 6155 6241 +86
Misses 608 608
|
kelsos
force-pushed
the
feat-toggle-button-group
branch
from
2d4af46 to
4cbb5f2
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.