Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feat: add skeleton loader #142

Merged
merged 2 commits into from
Nov 18, 2023
Merged

Conversation

tewshi
Copy link
Contributor

@tewshi tewshi commented Nov 17, 2023

No description provided.

@tewshi tewshi requested a review from a team as a code owner November 17, 2023 12:10
@codecov-commenter
Copy link

Codecov Report

Attention: 2 lines in your changes are missing coverage. Please review.

Comparison is base (fd39fb8) 91.31% compared to head (06b9241) 91.45%.

Files Patch % Lines
src/components/loaders/Skeleton.vue 98.07% 2 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #142      +/-   ##
==========================================
+ Coverage   91.31%   91.45%   +0.13%     
==========================================
  Files          39       41       +2     
  Lines        7023     7161     +138     
  Branches      295      297       +2     
==========================================
+ Hits         6413     6549     +136     
- Misses        610      612       +2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@kelsos kelsos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm @tewshi

Do you think we can also a backport to the compat library?

@kelsos kelsos merged commit 06b9241 into rotki:main Nov 18, 2023
4 checks passed
@tewshi
Copy link
Contributor Author

tewshi commented Nov 18, 2023

lgtm @tewshi

Do you think we can also a backport to the compat library?

Yes, definitely. Wanted this to get merged first.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants