Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(DataTable): update the typings to properly reflect items #181

Merged
merged 1 commit into from
Jan 25, 2024

Conversation

kelsos
Copy link
Member

@kelsos kelsos commented Jan 24, 2024

Closes #(issue_number)

@kelsos kelsos requested a review from a team as a code owner January 24, 2024 19:09
@codecov-commenter
Copy link

codecov-commenter commented Jan 24, 2024

Codecov Report

Attention: 1244 lines in your changes are missing coverage. Please review.

Comparison is base (8215d94) 60.51% compared to head (9873218) 61.42%.
Report is 2 commits behind head on main.

Files Patch % Lines
src/components/tables/DataTable.vue 56.50% 107 Missing ⚠️
src/components/cards/Card.stories.ts 0.00% 103 Missing ⚠️
src/components/tables/DataTable.stories.ts 0.00% 94 Missing ⚠️
...onents/forms/auto-complete/AutoComplete.stories.ts 0.00% 87 Missing ⚠️
src/components/overlays/dialog/Dialog.stories.ts 0.00% 81 Missing ⚠️
src/components/chips/Chip.stories.ts 0.00% 78 Missing ⚠️
src/components/steppers/Stepper.stories.ts 0.00% 50 Missing ⚠️
src/theme/index.ts 0.00% 50 Missing ⚠️
src/components/forms/text-area/TextArea.stories.ts 0.00% 39 Missing ⚠️
...onents/buttons/button-group/ButtonGroup.stories.ts 0.00% 36 Missing ⚠️
... and 38 more
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #181      +/-   ##
==========================================
+ Coverage   60.51%   61.42%   +0.90%     
==========================================
  Files          80       80              
  Lines       13796    14108     +312     
  Branches      462      445      -17     
==========================================
+ Hits         8349     8666     +317     
+ Misses       5447     5442       -5     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@kelsos kelsos marked this pull request as draft January 24, 2024 20:41
@kelsos kelsos force-pushed the generics-datatable branch from bede3ec to f832c5a Compare January 25, 2024 13:03
@kelsos kelsos marked this pull request as ready for review January 25, 2024 13:04
@kelsos kelsos force-pushed the generics-datatable branch from f832c5a to 9873218 Compare January 25, 2024 13:15
Copy link
Contributor

@tewshi tewshi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm!

@kelsos kelsos merged commit 9873218 into rotki:main Jan 25, 2024
5 checks passed
@kelsos kelsos deleted the generics-datatable branch January 25, 2024 14:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants