Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(Autocomplete): fix focus in autocomplete #321

Merged
merged 1 commit into from
Jan 2, 2025

Conversation

lukicenturi
Copy link
Contributor

Closes #(issue_number)

@lukicenturi lukicenturi requested a review from a team as a code owner December 25, 2024 16:28
@lukicenturi lukicenturi force-pushed the fix-autocomplete-focus branch from 94fde26 to 5e112f1 Compare December 25, 2024 16:30
@codecov-commenter
Copy link

codecov-commenter commented Dec 25, 2024

Codecov Report

Attention: Patch coverage is 25.00000% with 3 lines in your changes missing coverage. Please review.

Project coverage is 82.84%. Comparing base (2dc150c) to head (f38299d).

Files with missing lines Patch % Lines
...components/forms/auto-complete/RuiAutoComplete.vue 25.00% 3 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #321      +/-   ##
==========================================
- Coverage   82.85%   82.84%   -0.01%     
==========================================
  Files         115      115              
  Lines       10393    10393              
  Branches     1286     1284       -2     
==========================================
- Hits         8611     8610       -1     
- Misses       1782     1783       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@lukicenturi lukicenturi force-pushed the fix-autocomplete-focus branch 4 times, most recently from 8900590 to b53ff93 Compare December 31, 2024 15:13
@kelsos kelsos force-pushed the fix-autocomplete-focus branch from b53ff93 to f38299d Compare January 2, 2025 10:07
Copy link
Member

@kelsos kelsos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm thanks 👍

@kelsos kelsos merged commit 5ef2a92 into rotki:main Jan 2, 2025
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants