fix(nhsuk-frontend-react): pass table cell role to variations

rowellx68 · Jan 20, 2025 · dea2d48 · dea2d48
1 parent 71409be
commit dea2d48
Show file tree

Hide file tree

Showing 4 changed files with 8 additions and 2 deletions.
diff --git a/.changeset/flat-cobras-sparkle.md b/.changeset/flat-cobras-sparkle.md
@@ -0,0 +1,5 @@
+---
+"nhsuk-frontend-react": patch
+---
+
+fix(nhsuk-frontend-react): pass table cell role to variations
diff --git a/packages/nhsuk-frontend-react/src/components/content-presentation/table/Table.stories.tsx b/packages/nhsuk-frontend-react/src/components/content-presentation/table/Table.stories.tsx
@@ -119,7 +119,7 @@ export const ThreeColumnWithFirstCellAsHeader: Story = {
               </Table.Row>
             </Table.Head>
             <Table.Body>
-              <Table.Row>
+              <Table.Row role="none">
                 <Table.Cell>3-month</Table.Cell>
                 <Table.Cell variant="numeric">£31.25</Table.Cell>
                 <Table.Cell variant="numeric">£32.05</Table.Cell>

diff --git a/packages/nhsuk-frontend-react/src/components/content-presentation/table/Table.tsx b/packages/nhsuk-frontend-react/src/components/content-presentation/table/Table.tsx
@@ -242,6 +242,7 @@ const TableCell = ({
         }
       : {
           as: 'td',
+          role,
           ...(cellClassNames && { className: cellClassNames }),
         };
 

diff --git a/...rontend-react/src/components/content-presentation/table/__snapshots__/Table.spec.tsx.snap b/...rontend-react/src/components/content-presentation/table/__snapshots__/Table.spec.tsx.snap
@@ -221,7 +221,7 @@ exports[`should render a three column table with the first cell as a header 1`]
           >
             <tr
               class="nhsuk-table__row"
-              role="row"
+              role="none"
             >
               <th
                 class="nhsuk-table__header"
-Original file line number
+Diff line change
@@ Expand Up / @@ -242,6 +242,7 @@ const TableCell = ({ @@
             }
           : {
               as: 'td',
+              role,
               ...(cellClassNames && { className: cellClassNames }),
             };
@@ Expand Down @@