-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update for js-promise migration #8
Conversation
Hm — see: nodejs/node#46221 |
lgtm, do you want to merge this? |
This is failing because of the missing |
Ok I just read it. So yeah I guess we should set |
How do you want to do that? On the PureScript side or in the FFI file? It doesn't appear that fetch-core is setting any defaults right now. |
hmm yeah you are right. I don't know, what do you propose? |
It isn't required on all bodies — just stream bodies — so I've just added it as another option and set it when necessary. |
This updates the library to make use of
js-promise
instead ofweb-promise
, including relying on a newfetch-core
(another PR is open for that). This cannot be merged until the fetch-core PR merges, and then I can update the dependencies.