Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Preparing for embedded-hal 1.0 #26

Draft
wants to merge 1 commit into
base: hal-0.9
Choose a base branch
from

Conversation

JohnAZoidberg
Copy link

I had a tough time with all these generic traits and structs. It compiles but I haven't tested it yet.
Must for merge wait until embedded-hal 1.0 is released and rp2040-hal is also with support for that.

@ithinuel ithinuel changed the base branch from main to hal-0.9 August 29, 2023 10:57
@ithinuel
Copy link
Member

I changed the target branch of the PR. Some of the changes (namely to the latest rp2040-hal) have already been integrated there.

@JohnAZoidberg
Copy link
Author

Thank you, fixed up :)

@JohnAZoidberg
Copy link
Author

Tested build with: cargo build --target=thumbv6m-none-eabi

@ithinuel
Copy link
Member

I reviewed the current state of this crate and I have some doubts on what's the proper way to move forward with support for both embedded-hal 0.2.7 and 1.0-*

On the implementation side:

  • the cortex-m crate implements delay for embedded-hal 0.2.4
  • rp2040-hal implements various delay traits from embedded-hal 0.2.7 and 1.0-*

In theory, we should aim at supporting any delay source (provided they implement the HAL).
Moving the eh-1.0 now would deny support from at least cortex-m (until itself implements eh-1.0).

I also realized the CountDown support was broken, it should be as it is in: #27

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants