support latest smart-leds-trait #30
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ithinuel
requested changes
Mar 5, 2024
There was a problem hiding this comment.
Thank you for your contribution!
As far as I can see, only the esp-hal rely on smart-led 0.4 (which use smart-leds-trait).
I think that until this newer version gets widespread adoption, it’d be better to support both smart-leds-trait 0.2.1 and 0.3.
Would you mind adjusting your PR for that purpose?
|
Any suggestions on how to approach that? maybe they iterator type |
Perhaps like this? rolandoam#1 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
updated the code to match the new traits in smart-leds-trait (https://github.com/smart-leds-rs/smart-leds-trait/releases/tag/v0.3.0)