Kit versions: log version on start, and also check for known badness.

The combination of a year+ old core, and a modern coolforkit can initialize and startup, but then fails subsequently in hard to diagnose ways, so look for badness and log it early. Why use a deny-list? to work vs. master of core and also co-24.04 for now nicely. Signed-off-by: Michael Meeks <[email protected]> Change-Id: I9b9c94997afcc8faa8174b7339483f832ec87dd6
rparth07 · Oct 29, 2024 · 90bb966 · 90bb966
1 parent ce908e9
commit 90bb966
Showing 1 changed file with 17 additions and 0 deletions.
diff --git a/kit/Kit.cpp b/kit/Kit.cpp
@@ -3517,6 +3517,23 @@ void lokit_main(
 
             SigUtil::setVersionInfo(versionString);
 
+            LOG_INF("Kit core version is " << versionString);
+
+            // Extend the list on new releases
+            static const char *denyVersions[] = {
+                "\"22.05\"", "\"23.05\""
+            };
+            for (auto const &deny: denyVersions)
+            {
+                if (Util::findSubArray(versionString.c_str(), versionString.length(),
+                                       deny, strlen(deny)) >= 0)
+                {
+                    LOG_FTL("Mis-matching, obsolete core version, "
+                            "please update your packages: " << versionString);
+                    Util::forcedExit(EX_SOFTWARE);
+                }
+            }
+
             // Add some parameters we want to pass to the client. Could not figure out how to get
             // the configuration parameters from COOLWSD.cpp's initialize() or coolwsd.xml here, so
             // oh well, just have the value hardcoded in KitHelper.hpp. It isn't really useful to