Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

no op metadata json requests based on slot #171

Open
wants to merge 7 commits into
base: grpc-ingest
Choose a base branch
from
Open

no op metadata json requests based on slot #171

wants to merge 7 commits into from

Conversation

Nagaprasadvr
Copy link
Collaborator

@Nagaprasadvr Nagaprasadvr commented Oct 30, 2024 •
edited
Loading

  • add checks to skip downloading metadata json ( restrict if data exists)

@Nagaprasadvr Nagaprasadvr changed the base branch from main to grpc-ingest October 30, 2024 15:17
@Nagaprasadvr Nagaprasadvr marked this pull request as draft October 30, 2024 15:18
kespinola
kespinola requested changes Oct 31, 2024
View reviewed changes
Copy link
Collaborator

@kespinola kespinola left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

On a good track. We are missing migration for the new columns.

core/src/metadata_json.rs Outdated Show resolved Hide resolved
core/src/metadata_json.rs Outdated Show resolved Hide resolved
core/src/metadata_json.rs Outdated Show resolved Hide resolved
core/src/metadata_json.rs Outdated Show resolved Hide resolved
@Nagaprasadvr Nagaprasadvr force-pushed the das-22-no-op-metadata-json-requests-based-on-slot branch from 7384692 to d3cf166 Compare October 31, 2024 15:00
@Nagaprasadvr Nagaprasadvr marked this pull request as ready for review November 4, 2024 08:44
kespinola
kespinola requested changes Nov 4, 2024
View reviewed changes
Copy link
Collaborator

@kespinola kespinola left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is going to be annoying but I would like to add the updates to the db in a PR after grpc-ingest is merged in. As I noted in another comment we want to limit the impact of this PR on plerkle-ingest which means trying to limit our updates to program_transforms or the database model.

program_transformers/src/mpl_core_program/mod.rs Outdated Show resolved Hide resolved
program_transformers/src/lib.rs Outdated Show resolved Hide resolved
digital_asset_types/src/dao/generated/sea_orm_active_enums.rs Outdated Show resolved Hide resolved
@Nagaprasadvr Nagaprasadvr force-pushed the das-22-no-op-metadata-json-requests-based-on-slot branch from 5a74d25 to fb17d1a Compare November 4, 2024 15:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kespinola kespinola Awaiting requested review from kespinola

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Nagaprasadvr @kespinola