root_validation_failures fix

src/monitor/mod.rs

@@ -176,6 +176,7 @@ async fn load_accounts_with_infinite_retry(
 }
 
 async fn validate_tree_roots(rpc_client: &RpcClient, db_roots: Vec<(Pubkey, Hash)>) {
+    let mut root_validation_errors = 0;
     for chunk in db_roots.chunks(CHUNK_SIZE) {
         let pubkeys = chunk.iter().map(|(pubkey, _)| pubkey.clone()).collect();
         let accounts = load_accounts_with_infinite_retry(rpc_client, pubkeys).await;
@@ -188,11 +189,20 @@ async fn validate_tree_roots(rpc_client: &RpcClient, db_roots: Vec<(Pubkey, Hash
                     db_hash,
                     account_roots
                 );
-                return;
+                root_validation_errors += 1;
+                let pubkey_str = pubkey.to_string();
+                statsd_count!("root_validation_failures", 1, "pubkey" => &pubkey_str);
             }
         }
     }
-    metric! {
-        statsd_count!("root_validation_success", 1);
+
+    if root_validation_errors > 0 {
+        metric! {
+            statsd_gauge!("root_validation_success", 0);
+        }
+    } else {
+        metric! {
+            statsd_gauge!("root_validation_success", 1);
+        }
     }
 }