Skip to content

Commit

Permalink
Module tests: unify tags and annotate with relevant links
Browse files Browse the repository at this point in the history
  • Loading branch information
kontura authored and pkratoch committed Nov 13, 2024
1 parent c024caf commit b28f381
Show file tree
Hide file tree
Showing 33 changed files with 206 additions and 60 deletions.
Original file line number Diff line number Diff line change
@@ -1,3 +1,6 @@
# Missing module install command
# https://github.com/rpm-software-management/dnf5/issues/146
@xfail
@not.with_os=rhel__eq__8
Feature: Handling new stream with multicontext modules

Expand Down
3 changes: 3 additions & 0 deletions dnf-behave-tests/dnf/module/defaults-from-config-file.feature
Original file line number Diff line number Diff line change
@@ -1,3 +1,6 @@
# Missing module install command
# https://github.com/rpm-software-management/dnf5/issues/146
@xfail
Feature: On-disk modulemd data are preferred over repodata in case of a conflict

# Notes regarding operation of modulemd-defaults data merging:
Expand Down
3 changes: 3 additions & 0 deletions dnf-behave-tests/dnf/module/defaults-profiles.feature
Original file line number Diff line number Diff line change
@@ -1,3 +1,6 @@
# Missing module install command
# https://github.com/rpm-software-management/dnf5/issues/146
@xfail
Feature: Non-default profiles can be installed when explicitly specified on command line


Expand Down
7 changes: 6 additions & 1 deletion dnf-behave-tests/dnf/module/defaults-streams.feature
Original file line number Diff line number Diff line change
@@ -1,11 +1,11 @@
@dnf5
Feature: Default streams are properly switched to enabled

Background:
Given I use repository "dnf-ci-fedora-modular"
And I use repository "dnf-ci-fedora"


@dnf5
@bz1657213
Scenario: The default stream is enabled when requiring module is enabled
When I execute dnf with args "module enable meson:master"
Expand All @@ -20,6 +20,9 @@ Scenario: The default stream is enabled when requiring module is enabled
# DnfCiModulePackageDep:packagedep does not have any modular dependencies
# DnfCiModulePackageDep:moduledep requires nodejs module


@xfail
# Reported as https://github.com/rpm-software-management/dnf5/issues/1811
Scenario Outline: The default stream is enabled when its package is required by installed package of another module <description>
Given I use repository "dnf-ci-thirdparty"
When I execute dnf with args "module enable DnfCiModulePackageDep:<stream>"
Expand All @@ -41,6 +44,8 @@ Scenario Outline: The default stream is enabled when its package is required by
| (module deps set) | moduledep |


@xfail
# Reported as https://github.com/rpm-software-management/dnf5/issues/1811
Scenario: The default stream is enabled when its package is required by installed non-modular package
Given I use repository "dnf-ci-thirdparty"
When I execute dnf with args "install anitras-dance"
Expand Down
13 changes: 10 additions & 3 deletions dnf-behave-tests/dnf/module/defaults.feature
Original file line number Diff line number Diff line change
@@ -1,11 +1,11 @@
@dnf5
Feature: Modulemd defaults are followed by dnf module commands

Background:
Given I use repository "dnf-ci-fedora-modular"
And I use repository "dnf-ci-fedora"


@dnf5
Scenario: The default stream is used when enabling a module
When I execute dnf with args "module enable nodejs"
Then the exit code is 0
Expand All @@ -14,7 +14,6 @@ Scenario: The default stream is used when enabling a module
| nodejs | enabled | 8 | |


@dnf5
@bz1629702
Scenario: The default streams are identified in the output of module list
When I execute dnf with args "module list nodejs"
Expand All @@ -27,14 +26,16 @@ Scenario: The default streams are identified in the output of module list
| nodejs | 11 | development, minimal, default |


@dnf5
@bz1618553
Scenario: Default profiles are identified in the output of dnf info
When I execute dnf with args "module info nodejs"
Then the exit code is 0
And stdout contains "Default profiles : default"


# Missing module install command
# https://github.com/rpm-software-management/dnf5/issues/146
@xfail
Scenario: Default stream and profile are used when installing a module with no enabled profile
When I execute dnf with args "module install nodejs"
Then the exit code is 0
Expand All @@ -43,6 +44,9 @@ Scenario: Default stream and profile are used when installing a module with no e
| nodejs | enabled | 8 | default |


# Missing module install command
# https://github.com/rpm-software-management/dnf5/issues/146
@xfail
@bz1582450
Scenario: Default profile(s) is used when installing a module with enabled stream
When I execute dnf with args "module enable nodejs:10"
Expand All @@ -57,6 +61,9 @@ Scenario: Default profile(s) is used when installing a module with enabled strea
| nodejs | enabled | 10 | default |


# Missing module install command
# https://github.com/rpm-software-management/dnf5/issues/146
@xfail
Scenario: Default profile is installed when installing a non-default stream with dnf module install module:stream
When I execute dnf with args "module install nodejs:10"
Then the exit code is 0
Expand Down
3 changes: 3 additions & 0 deletions dnf-behave-tests/dnf/module/demodularization.feature
Original file line number Diff line number Diff line change
@@ -1,3 +1,6 @@
# Demodularization is not implemented
# https://github.com/rpm-software-management/dnf5/issues/1852
@xfail
Feature: Modular filtering must ignore demodularized rpms

Background:
Expand Down
15 changes: 12 additions & 3 deletions dnf-behave-tests/dnf/module/disable.feature
Original file line number Diff line number Diff line change
@@ -1,3 +1,4 @@
@dnf5
Feature: Disabling module stream


Expand All @@ -6,7 +7,6 @@ Background:
Given I use repository "dnf-ci-fedora"


@dnf5
@bz1677640
Scenario: I can disable a module when specifying module name
When I execute dnf with args "module enable nodejs:8"
Expand All @@ -22,7 +22,6 @@ Scenario: I can disable a module when specifying module name
| nodejs | disabled | | |


@dnf5
# this is not test for @bz1677640, but test is failing until the bug is fixed
Scenario: Disabling an already disabled module should pass
When I execute dnf with args "module enable nodejs:8"
Expand All @@ -40,6 +39,9 @@ Scenario: Disabling an already disabled module should pass
And stdout contains "Nothing to do."


# Missing report about unneeded information
# https://github.com/rpm-software-management/dnf5/issues/1028
@xfail
@bz1649261
Scenario Outline: I can disable a module when specifying <spec>
When I execute dnf with args "module enable nodejs:8"
Expand All @@ -60,6 +62,11 @@ Examples:
| version | nodejs:10:20180920144631 |


# Missing module install command
# https://github.com/rpm-software-management/dnf5/issues/146
# Missing report about unneeded information
# https://github.com/rpm-software-management/dnf5/issues/1028
@xfail
@bz1649261
Scenario Outline: I can disable a module with installed profile when specifying <spec>
When I execute dnf with args "module install nodejs:10/default"
Expand All @@ -82,7 +89,6 @@ Examples:
| version | nodejs:10:20180920144631 |


@dnf5
@bz1613910
Scenario: It is possible to disable an enabled default stream
When I execute dnf with args "module enable nodejs"
Expand All @@ -102,6 +108,9 @@ Scenario: It is possible to disable an enabled default stream
| nodejs | 8 [d][x] | development, minimal, default [d] |


# Missing module install command
# https://github.com/rpm-software-management/dnf5/issues/146
@xfail
@bz1653623
@bz1583596
Scenario: User is informed about disabling installed profiles when disabling a module
Expand Down
14 changes: 13 additions & 1 deletion dnf-behave-tests/dnf/module/enable-contexts.feature
Original file line number Diff line number Diff line change
@@ -1,8 +1,12 @@
@dnf5
Feature: Dependency resolution must occur to determine the appropriate dependent stream+context to use

Background:
Given I use repository "dnf-ci-thirdparty-modular"

# Missing module install command
# https://github.com/rpm-software-management/dnf5/issues/146
@xfail
Scenario: Appropriate context is selected depending on the enabled required module stream
When I execute dnf with args "module enable biotope:wood"
Then the exit code is 0
Expand All @@ -18,6 +22,9 @@ Scenario: Appropriate context is selected depending on the enabled required modu
| install-group | raspberry-0:1.0-1.wood.x86_64 |


# Missing module install command
# https://github.com/rpm-software-management/dnf5/issues/146
@xfail
Scenario: Appropriate context is selected depending on the enabled required module stream - cross check
When I execute dnf with args "module enable biotope:garden"
Then the exit code is 0
Expand All @@ -33,6 +40,9 @@ Scenario: Appropriate context is selected depending on the enabled required modu
| install-group | raspberry-0:1.0-1.garden.x86_64 |


# Missing module install command
# https://github.com/rpm-software-management/dnf5/issues/146
@xfail
Scenario: Any suitable context is selected when more options are possible
When I execute dnf with args "module install berry:raspberry/default"
Then the exit code is 0
Expand All @@ -44,7 +54,6 @@ Scenario: Any suitable context is selected when more options are possible
Then the exit code is 0


@dnf5
@not.with_os=rhel__eq__8
Scenario: An error is printed with no stream and context is possible to enable
When I execute dnf with args "module enable biotope:pond"
Expand All @@ -56,6 +65,9 @@ Scenario: An error is printed with no stream and context is possible to enable
And stderr contains "module biotope:wood:1:\.x86_64 conflicts with module\(biotope\) provided by biotope:pond:1:\.x86_64"


# Missing module install command
# https://github.com/rpm-software-management/dnf5/issues/146
@xfail
@not.with_os=rhel__eq__8
@bz1670496
Scenario: An error is printed when trying to install different context
Expand Down
20 changes: 10 additions & 10 deletions dnf-behave-tests/dnf/module/enable-dependencies.feature
Original file line number Diff line number Diff line change
@@ -1,10 +1,14 @@
@dnf5
Feature: Enable module streams with modular dependencies


Background:
Given I use repository "dnf-ci-thirdparty-modular"


# Module defaults from /etc/dnf/modules.defaults.d/ are not loaded
# https://github.com/rpm-software-management/dnf5/issues/1853
@xfail
Scenario: Enabling a default stream depending on a default stream
Given I create file "/etc/dnf/modules.defaults.d/defaults.yaml" with
"""
Expand Down Expand Up @@ -38,6 +42,10 @@ Scenario: Enabling a default stream depending on a default stream
| beverage | enabled | soda | |
| fluid | enabled | water | |


# Module defaults from /etc/dnf/modules.defaults.d/ are not loaded
# https://github.com/rpm-software-management/dnf5/issues/1853
@xfail
@bz1648839
Scenario: Enabling a default stream depending on a non-default stream
Given I create file "/etc/dnf/modules.defaults.d/defaults.yaml" with
Expand Down Expand Up @@ -72,7 +80,6 @@ Scenario: Enabling a default stream depending on a non-default stream
| beverage | enabled | soda | |
| fluid | enabled | water | |

@dnf5
Scenario: Enabling a non-default stream depending on a default stream
Given I create file "/etc/dnf/modules.defaults.d/defaults.yaml" with
"""
Expand Down Expand Up @@ -107,7 +114,6 @@ Scenario: Enabling a non-default stream depending on a default stream
| fluid | enabled | water | |


@dnf5
# rely on merging bz1649261 fix
Scenario: Enabling a disabled stream depending on a default stream
Given I create file "/etc/dnf/modules.defaults.d/defaults.yaml" with
Expand Down Expand Up @@ -148,7 +154,6 @@ Scenario: Enabling a disabled stream depending on a default stream
| fluid | enabled | water | |


@dnf5
# rely on merging bz1649261 fix
Scenario: Enabling a disabled stream depending on a non-default stream
Given I create file "/etc/dnf/modules.defaults.d/defaults.yaml" with
Expand Down Expand Up @@ -189,7 +194,6 @@ Scenario: Enabling a disabled stream depending on a non-default stream
| fluid | enabled | water | |


@dnf5
@bz1622566
Scenario: Enabling a non-default stream depending on a non-default stream
When I execute dnf with args "module enable food-type:meat"
Expand All @@ -204,7 +208,6 @@ Scenario: Enabling a non-default stream depending on a non-default stream
| ingredience | enabled | chicken | |


@dnf5
Scenario: Enable a module and its dependencies by specifying profile
When I execute dnf with args "module enable food-type:meat/default"
Then the exit code is 0
Expand Down Expand Up @@ -242,7 +245,7 @@ Scenario: Enable a module and its dependencies by specifying profile
# | food-type | disabled | | |
# | ingredience | disabled | | |

@dnf5

@not.with_os=rhel__eq__8
Scenario: Module cannot be disabled if there are other enabled streams requiring it
When I execute dnf with args "module enable food-type:meat"
Expand All @@ -266,7 +269,6 @@ Scenario: Module cannot be disabled if there are other enabled streams requiring
| ingredience | enabled | chicken | |


@dnf5
Scenario: Enable the default stream of a module and its dependencies
When I execute dnf with args "module enable food-type"
Then the exit code is 0
Expand Down Expand Up @@ -304,7 +306,7 @@ Scenario: Enable the default stream of a module and its dependencies
# | food-type | enabled | meat | |
# | ingredience | enabled | chicken | |

@dnf5

# rely on merging bz1649261 fix
@not.with_os=rhel__eq__8
Scenario: Cannot enable a stream depending on a disabled module
Expand All @@ -329,7 +331,6 @@ Scenario: Cannot enable a stream depending on a disabled module
| ingredience | disabled | | |


@dnf5
Scenario: Enable a module stream dependent on a module with a default stream
When I execute dnf with args "module enable food-type:edible"
Then the exit code is 0
Expand All @@ -343,7 +344,6 @@ Scenario: Enable a module stream dependent on a module with a default stream
| ingredience | enabled | orange | |


@dnf5
Scenario: Enable a module stream dependent on a module without default stream
Given I use repository "dnf-ci-fedora-modular-updates"
When I execute dnf with args "module enable nodejs:12"
Expand Down
Loading

0 comments on commit b28f381

Please sign in to comment.