Add test for installing installonly through provides #1391
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kontura
force-pushed
the
dnf-4-stack-avoid_reinstalling_installonly
branch
from
92e4bd8 to
cb3b85e
Compare
j-mracek
reviewed
Oct 3, 2023
|
|
||
| Summary: The Linux kernel | ||
|
|
||
| Provides: kernel = %{version}-%{release} |
There was a problem hiding this comment.
May I ask you why you have explicit provide of kernel?
There was a problem hiding this comment.
It was present in our already existing kernel specs, mostly I just copied it.
I have removed it.
j-mracek
reviewed
Oct 3, 2023
dnf-behave-tests/fixtures/specs/kernel/kernel-3.0.0-1.fc29.spec
Outdated
Show resolved
Hide resolved
j-mracek
reviewed
Oct 3, 2023
dnf-behave-tests/fixtures/specs/kernel/kernel-3.0.0-1.fc29.spec
Outdated
Show resolved
Hide resolved
j-mracek
reviewed
Oct 3, 2023
dnf-behave-tests/fixtures/specs/kernel/kernel-3.0.0-1.fc29.spec
Outdated
Show resolved
Hide resolved
j-mracek
suggested changes
Oct 3, 2023
kontura
force-pushed
the
dnf-4-stack-avoid_reinstalling_installonly
branch
from
cb3b85e to
56df15d
Compare
Ok, I have removed all of the provides that I think were not needed for the tests. |
j-mracek
approved these changes
Oct 4, 2023
|
LGTM |
|
@kontura Thank you very much for fixing a complex issue |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For: https://issues.redhat.com/browse/RHEL-1253
(https://bugzilla.redhat.com/show_bug.cgi?id=2163474)
Requires: rpm-software-management/libdnf#1625