Onboard Tmt #1405
Merged
Onboard Tmt #1405
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
10 tasks
m-blaha
reviewed
Nov 10, 2023
plans/main.fmf
Outdated
| BASE: "fedora:39" | ||
| - when: distro == fedora-rawhide | ||
| environment: | ||
| BASE: "fedora:rawhide" |
There was a problem hiding this comment.
This adjustments are a bit unfortunate - we will need to adjust them every time a new Fedora is branched. Would it be possible to use original distro value and do something like this?
...container-test build --base $(echo "$BASE" | tr '-' ':') ...
There was a problem hiding this comment.
for fedora no problem but we'll need to adjust stuff for centos, rhel etc in the future
There was a problem hiding this comment.
@m-blaha I tweaked the --base option but we will need to be smarter if we'll want to add Centos tests too
|
/packit test |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR onboards tmt to test DNF5 only.
The checks will run only when requested via
/packit testsor/packit tests rpm-software-management/dnf5#PRNUMBER.The PR also checks tmt plans with pre-commit tests.