Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adjust versionlock locking tests to dnf5 #1434

Merged
merged 3 commits into from
Feb 15, 2024
Merged

Conversation

m-blaha
Copy link
Member

@m-blaha m-blaha commented Jan 9, 2024

  • change config format to new versionlock.toml format
  • drop test for different patterns of locked versions. Globs are not
    supported any more.
  • version pattern (1.3.*) test changed to proper versions interval
    (>=1.3 && < 1.4)

Requires: rpm-software-management/dnf5#1121

- change config format to new versionlock.toml format
- drop test for different patterns of locked versions. Globs are not
  supported any more.
- version pattern (1.3.*) test changed to proper versions interval
  (>=1.3 && < 1.4)
@m-blaha m-blaha force-pushed the mblaha/versionlock branch from df7481b to 7f38aae Compare January 9, 2024 12:24
I've removed most of the tests, because dnf5 works correctly without
versionlock configuration file.
@m-blaha m-blaha marked this pull request as ready for review January 19, 2024 13:51
@jan-kolarik jan-kolarik self-assigned this Feb 13, 2024
@jan-kolarik
Copy link
Member

jan-kolarik commented Feb 15, 2024

CI for ci-dnf-stack is currently out of service, so testing locally.

I am getting one failure in versionlock-list-manipulation.feature with scenario "I can exclude mutliple packages when one is already excluded":

Assertion Failed: Stderr is not: No package found for "wget".
      Captured stdout:
      expected                      |  found
      No package found for "wget".  |  Package "wget" is already excluded.

And it makes sense, @m-blaha please review and eventually change the expected stderr to Package "wget" is already excluded..

@m-blaha
Copy link
Member Author

m-blaha commented Feb 15, 2024

@jan-kolarik Ech sorry. I have it fixed locally, but forgot to commit and push...

Mostly changing checked outputs to match what dnf5 actually prints.
Dropped test for --raw switch, which is not going to be supported in
dnf5.
@jan-kolarik jan-kolarik merged commit 5ee71b9 into main Feb 15, 2024
2 of 5 checks passed
@jan-kolarik jan-kolarik deleted the mblaha/versionlock branch February 15, 2024 16:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants