-
Notifications
You must be signed in to change notification settings - Fork 47
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Tests for pre-transaction-actions plugin, improve post-transaction-actions plugin test #1459
Tests for pre-transaction-actions plugin, improve post-transaction-actions plugin test #1459
Conversation
It seems that CI il is not related to this PR. |
Yes that is an issue caused by libsolv update, here is a fix to update our CI: #1452. |
| out | | | ||
|
||
|
||
Scenario: Do not traceback when reason change is in transaction |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The Scenario
name mentions reason change but I don't see any changing reasons in the test.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
| key | value | | ||
| installonlypkgs | installonlyA | | ||
| installonly_limit | 2 | | ||
When I execute dnf with args "-v install installonlyA-1.0" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is the -v
flag required in these executions?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
No. I will remove it.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
-v is redundant
""" | ||
When I execute dnf with args "-v install installonlyA-2.2" | ||
Then the exit code is 0 | ||
And Transaction is following |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reason change happen when install and remove kernel in one transaction. This is a workaround that fix logic of history DB in background of DNF.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It looks like that reason change is added only in DNF5, and not in DNF4
Created from tests for post-transaction-actions.
- to store/check all lines use appending ">>" instead of ">" in output redirection - removed unnecessary dnf argument "-v" - added comment about reason change
c497dcc
to
823563f
Compare
Thank you, the failing tests are not related. |
dfb129e
into
rpm-software-management:dnf-4-stack
Since rpm-software-management#1459 the tests require the pre-transaction plugin.
Since #1459 the tests require the pre-transaction plugin.
Created from tests for post-transaction-actions.
Requires rpm-software-management/dnf-plugins-core#523