Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tests for repoquery -f, -l #1488

Merged
merged 2 commits into from
May 15, 2024
Merged

Conversation

jan-kolarik
Copy link
Member

@jan-kolarik jan-kolarik commented Apr 19, 2024

@jan-kolarik
Copy link
Member Author

jan-kolarik commented Apr 19, 2024

After creating the tests for dnf4 branch, I realized these are already present in the dnf5, so no need to backport it there.

@m-blaha
Copy link
Member

m-blaha commented Apr 19, 2024

Just thinking whether it would have some maintenance benefit to keep repoquery/files.feature the same (or as similar as possible) for dnf-4-stack and main branches. What do you think?

@jan-kolarik
Copy link
Member Author

Just thinking whether it would have some maintenance benefit to keep repoquery/files.feature the same (or as similar as possible) for dnf-4-stack and main branches. What do you think?

You're right, I'll try to reuse the tests from dnf5, drop the unusable ones and add the missing test for -l in dnf5.

@m-blaha
Copy link
Member

m-blaha commented Apr 19, 2024

The -l is not completely missing - it just uses long variant of the option --files.

@jan-kolarik jan-kolarik force-pushed the jkolarik/repoquery-files-tests branch from 34dc60a to b21dd86 Compare May 14, 2024 07:27
@jan-kolarik
Copy link
Member Author

I've backported the tests from the dnf5 branch and did small adjustments.

@jan-kolarik
Copy link
Member Author

jan-kolarik commented May 15, 2024

Hmm, it seems the CI tests are failing because F39 environment is used for testing, though the filelists changes were introduced in >= F40. These three failing tests are passing for me locally.

@jan-kolarik
Copy link
Member Author

I think we should better migrate also the dnf4 branch of CI stack to use TMT testing, so we get the different chroots testing "for free".

@jan-kolarik jan-kolarik force-pushed the jkolarik/repoquery-files-tests branch from bc7e79c to 1a1fe39 Compare May 15, 2024 09:25
@jan-kolarik
Copy link
Member Author

Hmm, so I forgot to actually add the testing repository that is used in the tests. Anyway, it's interesting no error about that non-existing repo was thrown.

Copy link
Member

@m-blaha m-blaha left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@m-blaha m-blaha merged commit 26355dc into dnf-4-stack May 15, 2024
3 checks passed
@m-blaha m-blaha deleted the jkolarik/repoquery-files-tests branch May 15, 2024 10:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

3 participants