Review [a-d]* tests for dnf5 #1568
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
m-blaha
commented
Oct 15, 2024
m-blaha
commented
- added reference to related github issues for failing tests
- passing tests are enabled/adjusted
- tests that does not make sense any more are dropped
- test for aliases functionality is re-worked to cover dnf5 implementation
- drop alias-command.feature since the command is not supported in dnf5 - create a new feature to test dnf5 aliasing functionality
- removed dnf4 only test - removed test that rely on expired_repos.json, such file is not used by dnf5 any more
- use correct exit code - use correct error message
- one failing scenario adjusted to dnf5 - for scenarios not passing on dnf5 added links to related github issues
The --debuglevel option has been dropped in dnf5, only debuglevel config option is supposed to be supported. Unfortunately this config option is still not implemented, so there is nothing to test. rpm-software-management/dnf5#1774
- move the @dnf5 decorator to the Feature level - remove remaining dnf4 output testing
Added a link to the github issue tracking Python plugins problem.
- one already passing test tagged with @dnf5 - added links to github issues for failing tests
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.