Add libdnf5 and libdnf5-cli rpminspect ABI check plan #1595
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kontura
added a commit
to kontura/dnf5
that referenced
this pull request
Nov 19, 2024
The plan: rpm-software-management/ci-dnf-stack#1595 Since the plan compares ABI with latests rawhide build target the job only to rawhide.
It compares ABI of current PR build with the last nightly build. This means the ABI diff will mostly show only very recent changes. Since it already uses rpminspect we could also enable additional checks if we want to, currently it uses `-T abidiff` to only work with ABI. It also sets `-t BAD`, this affects the exit code so that only ABI breaks cause the action to fail. Reports with `VERIFY` (such as adding new symbols) doesn't fail it.
jan-kolarik
approved these changes
Nov 25, 2024
|
Thank you! This is much appreciated 🙂 |
github-merge-queue bot
pushed a commit
to rpm-software-management/dnf5
that referenced
this pull request
Nov 25, 2024
The plan: rpm-software-management/ci-dnf-stack#1595 Since the plan compares ABI with latests rawhide build target the job only to rawhide.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It compares ABI of current PR build with the last nightly rawhide build. This means the ABI diff will mostly show only very recent changes.
Since it already uses
rpminspectwe could also enable additional checks if we wanted to.The plan will be invoked from dnf5 upstream PRs.