Adjust reposync tests for dnf5 behavior #1599
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kontura
requested changes
Dec 5, 2024
| @@ -1,4 +1,4 @@ | |||
| @xfail | |||
| @dnf5 | |||
| # The plugin is missing: https://github.com/rpm-software-management/dnf5/issues/931 | |||
| @@ -377,11 +387,34 @@ Scenario: Reposync does not stop downloading packages on the first error | |||
| # remove one of reposynced packages to cause download error | |||
| And I delete file "//{context.dnf.tempdir}/repos/simple-base/src/dedalo-signed-1.0-1.fc29.src.rpm" | |||
| When I execute dnf with args "reposync --download-path={context.dnf.tempdir}" | |||
| Then the exit code is 1 | |||
| And stdout contains "\[FAILED\] dedalo-signed-1.0-1.fc29.src.rpm: No more mirrors to try - All mirrors were already tried without success" | |||
| Then the exit code is 0 | |||
There was a problem hiding this comment.
Should we rather mark the test as @xfail and add the link to the relevant issue?
There was a problem hiding this comment.
Agreed, that's definitely better solution.
Comment on lines
-263
to
+273
| http://localhost:[0-9]+/repodata/primary.xml.gz | ||
| http://localhost:[0-9]+/repodata/filelists.xml.gz | ||
| http://localhost:[0-9]+/repodata/other.xml.gz | ||
| http://localhost:[0-9]+/repodata/comps.xml | ||
| http://localhost:[0-9]+/repodata/comps.xml.gz | ||
| http://localhost:[0-9]+/repodata/primary.xml.zst | ||
| http://localhost:[0-9]+/repodata/filelists.xml.zst | ||
| http://localhost:[0-9]+/repodata/other.xml.zst | ||
| http://localhost:[0-9]+/repodata/comps.xml.zst |
There was a problem hiding this comment.
I believe the order has changed for this test and the one above since it uses the std::map.
- progress bars output goes to stderr instead of stdout - full NEVRA including epoch is used - --downloadcomps support is dropped - --newest-only is yet not fully supported for modules - backported dnf4 test for not downloading the same NEVRA multiple times
m-blaha
force-pushed
the
mblaha/reposync
branch
from
42f8c3d to
ee11e87
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Requires: rpm-software-management/dnf5#1903